Skip to content

feat(formatter): correct comments printing for ConditionalExpression #12913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: 08-07-feat_formatter_correct_comments_printing_for_switchstatement
Choose a base branch
from
Draft

feat(formatter): correct comments printing for ConditionalExpression #12913

wants to merge 1 commit into from
+335 −21

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Aug 8, 2025

No description provided.

@github-actions github-actions bot added A-formatter Area - Formatter C-enhancement Category - New feature or request labels Aug 8, 2025
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Aug 8, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Aug 8, 2025
Open
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 8, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #12913 will not alter performance

Comparing 08-08-feat_formatter_correct_comments_printing_for_conditionalexpression (79dd4be) with 08-07-feat_formatter_correct_comments_printing_for_switchstatement (8f566e6)

Summary

✅ 34 untouched benchmarks

@Dunqing Dunqing force-pushed the 08-08-feat_formatter_correct_comments_printing_for_conditionalexpression branch from 0a0d8fc to 984594c Compare August 9, 2025 13:45
@graphite-app graphite-app bot changed the base branch from 08-07-feat_formatter_correct_comments_printing_for_switchstatement to graphite-base/12913 August 10, 2025 07:19
@Dunqing Dunqing force-pushed the 08-08-feat_formatter_correct_comments_printing_for_conditionalexpression branch from 984594c to 79dd4be Compare August 11, 2025 00:53
@Dunqing Dunqing force-pushed the graphite-base/12913 branch from ed378fc to 8f566e6 Compare August 11, 2025 00:53
@Dunqing Dunqing changed the base branch from graphite-base/12913 to 08-07-feat_formatter_correct_comments_printing_for_switchstatement August 11, 2025 00:53
@Dunqing Dunqing mentioned this pull request Aug 11, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-formatter Area - Formatter C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dunqing