test: skip broken test which asks for ssh key #9641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just re-checked
pnpm/resolving/git-resolver/src/parseBareSpecifier.ts Lines 139 to 146 in dc8a1f0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assumption in this test looks either invalid or broken (impl detail changed? how was this supposed to behave?)
When running this test on
main, it asks me for a password to my ssh key, github username, and github passwordIt passes if I just provide none of that and press enter three times
It hangs if I don't react
Given that, I treat this test as being broken
It could likely be fixed though? But having a broken test non-skipped looks more problematic