test: replace jest (PoC) #9649
Draft
test: replace jest (PoC) #9649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
820aaba to
2181b29
Compare
|
Seems to still be slow |
|
I doubt that changing the test runner would make a big difference. The tests are slow because most of the tests are e2e tests that make a lot of network requests and fs operations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an experiment
I wonder what part of tests being slow comes from jest and how would tests perform with it replaced
This also comes with 5-6 test files changed to prefer doMock instead of mock -- will likely file that as a separate PR with explanation