refactor: add node: protocol to imports
#9703
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7d4746 to
57b5e19
Compare
TBH, I don't understand what is the difficulty. There are like 3 or 4 standard libraries. |
It’s just much easier to sift through many files to analyse dependencies. Same logic also applies to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m currently looking at cleaning things up a bit, and cutting down on some of the dependencies (e.g. replace
rimrafwith the builtin nodermimplementation, à la e18e/ecosystem-issues#178 (comment)),But it’s currently difficult to differentiate between node
imports and external dependencies. This PR addresses that.It might be worth considering adding an extra rule to the
eslintconfig (https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-node-protocol.md), or even https://biomejs.dev/linter/rules/use-nodejs-import-protocol, if #9740 goes ahead.