Preserve features in type resolver #22634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08c94e1 to
0ab7ac7
Compare
0ab7ac7 to
46fb222
Compare
While we previously preserved unresolved features set directly on message and enum types and the edition specified in the file, and features set at the file or nesting scopes were discarded. This throws away important semantic information, resulting in incorrect Type and Enum objects under editions. This change solves the problem by partially resolving features down to the scope returned. Users will still need to figure out the defaults for each edition on their own, but these can now be converted back into descriptors and built correctly. PiperOrigin-RevId: 791393429
46fb222 to
c7030f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve features in type resolver
While we previously preserved unresolved features set directly on message and enum types and the edition specified in the file, and features set at the file or nesting scopes were discarded. This throws away important semantic information, resulting in incorrect Type and Enum objects under editions.
This change solves the problem by partially resolving features down to the scope returned. Users will still need to figure out the defaults for each edition on their own, but these can now be converted back into descriptors and built correctly.