Don't return early when encountering a numeric field with a set hasbit in VerifyHasBitConsistency, add tests. #22947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6342c04 to
e9147cd
Compare
9b0b093 to
afe1ef7
Compare
afe1ef7 to
bbddd42
Compare
…t in VerifyHasBitConsistency, add tests. This is a DCHECK that runs in debug builds, but unless there is a bug in protobuf internal code or a misuse of protobuf by users, this check should not fire. These tests verify that the check correctly catches the types of errors we want it to. PiperOrigin-RevId: 791337631
bbddd42 to
cbb6537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't return early when encountering a numeric field with a set hasbit in VerifyHasBitConsistency, add tests.
This is a DCHECK that runs in debug builds, but unless there is a bug in protobuf internal code or a misuse of protobuf by users, this check should not fire. These tests verify that the check correctly catches the types of errors we want it to.