Add conformance test cases for malformed nanos fields on Durations and Timestamps. #22995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0d52b0 to
7d9d267
Compare
7d9d267 to
5b0e479
Compare
9481e47 to
a003fe7
Compare
…d Timestamps. Durations have a validity restriction on `nanos` that: - The range allowed is (-1s..1s) exclusive - The sign must match the sign of `secs` (for 0 secs both positive and negative values of nanos are allowed) Timestamps have a validity restriction on `nanos` that: - The range allowed is [0..1s) These cases have always been commented as only being valid under these constraints, and other validity constraints are already checked to be handled as ProtoJSON serialize-failures, but this particular condition was not covered by the conformance suite. PiperOrigin-RevId: 791194939
a003fe7 to
a6bdd0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add conformance test cases for malformed nanos fields on Durations and Timestamps.
Durations have a validity restriction on
nanosthat:secs(for 0 secs both positive and negative values of nanos are allowed)Timestamps have a validity restriction on
nanosthat:These cases have always been commented as only being valid under these constraints, and other validity constraints are already checked to be handled as ProtoJSON serialize-failures, but this particular condition was not covered by the conformance suite.