Add JSON conformance test that a single value provided for a repeated field should parse fail. #23003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2806d4e to
9da9919
Compare
… field should parse fail. This adds tests for both an object instead of an array for a repeated submessage field, and a number instead of an array for a repeated int32 field. C++Proto fails both tests. Pure-PHP fails this test only for the numbers case. PiperOrigin-RevId: 791266294
9da9919 to
9806994
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add JSON conformance test that a single value provided for a repeated field should parse fail.
This adds tests for both an object instead of an array for a repeated submessage field, and a number instead of an array for a repeated int32 field.
C++Proto fails both tests. Pure-PHP fails this test only for the numbers case.