Skip to content

Cherry pick #22875 and #22922 which raise warnings when assign bool to int/enum #23030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2025
Merged

Cherry pick #22875 and #22922 which raise warnings when assign bool to int/enum #23030

merged 2 commits into from
Aug 7, 2025

Conversation

anandolee
Copy link
Contributor

@anandolee anandolee commented Aug 6, 2025 •
edited
Loading

Cherry pick #22875 and #22922
Will turn into errors in 34.0 realse.

@anandolee
Raise warnings when assign bool to int/enum field in Python Proto. Th…
0ea6a4a 
…is will turn into error in 34.0 release.

PiperOrigin-RevId: 789619218
@anandolee
Fix --_BoolWarningCount to _BoolWarningCount -= 1
3661234 
PiperOrigin-RevId: 789836477
@anandolee anandolee requested a review from a team as a code owner August 6, 2025 20:44
@anandolee anandolee requested review from haberman, zhangskz and googleberg and removed request for a team and haberman August 6, 2025 20:44
@anandolee anandolee changed the title Cherry pick 4ee55d7 and 888e287c6 which raise warnings when assign bool to int/enum Cherry pick #22875 and 888e287c6 which raise warnings when assign bool to int/enum Aug 6, 2025
@anandolee anandolee changed the title Cherry pick #22875 and 888e287c6 which raise warnings when assign bool to int/enum Cherry pick #22875 and #22922 which raise warnings when assign bool to int/enum Aug 6, 2025
@anandolee anandolee enabled auto-merge (squash) August 6, 2025 22:21
@anandolee anandolee removed the request for review from zhangskz August 6, 2025 23:43
@anandolee anandolee added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 6, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 6, 2025
@anandolee anandolee merged commit 0b25f7b into protocolbuffers:32.x Aug 7, 2025
203 of 205 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@googleberg googleberg googleberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anandolee @googleberg