Use Rust 1.79 for Bazel and nightly for Cargo #23060
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ced272 to
abecbd9
Compare
We need to use a recent nightly release to be able to use the `--workspace` flag to `cargo publish`. Our minimum supported Rust version is 1.79, so I think we should test that version with Bazel to make sure we stay compatible. Our Bazel build is currently using 1.86 since that is the default from rules_rust, but this change explicitly selects 1.79. I also tried having Bazel use a more recent version, but unfortunately rules_rust is broken for 1.87 and up, due to name mangling changes in rustc: bazelbuild/rules_rust#3459 As soon as Rust 1.90 is released, we can start using that with Cargo instead of nightly. PiperOrigin-RevId: 792701669
abecbd9 to
27618a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Rust 1.79 for Bazel and nightly for Cargo
We need to use a recent nightly release to be able to use the
--workspaceflag to
cargo publish. Our minimum supported Rust version is 1.79,so I think we should test that version with Bazel to make sure we stay
compatible. Our Bazel build is currently using 1.86 since that is the default
from rules_rust, but this change explicitly selects 1.79.
I also tried having Bazel use a more recent version, but unfortunately
rules_rust is broken for 1.87 and up, due to name mangling changes in rustc:
bazelbuild/rules_rust#3459
As soon as Rust 1.90 is released, we can start using that with Cargo instead of
nightly.