Skip to content

Draft: Fix the bug: PrecisionMvNormalRV missing factor of 1/2 for log determinant in logp function #7811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Draft: Fix the bug: PrecisionMvNormalRV missing factor of 1/2 for log determinant in logp function #7811

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b092df6
Fix the formula for logp computation
olp-cs Jun 7, 2025
4b2a3dd
Merge branch 'pymc-devs:main' into dev
olp-cs Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix the formula for logp computation
  • Loading branch information
@olp-cs
olp-cs committed Jun 7, 2025
commit b092df6902aab2a23498b4aa85a35b757be72017
2 changes: 1 addition & 1 deletion pymc/distributions/multivariate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ def precision_mv_normal_logp(op: PrecisionMvNormalRV, value, rng, size, mean, ta
delta = value - mean
quadratic_form = delta.T @ tau @ delta
logdet, posdef = _logdet_from_cholesky(nan_lower_cholesky(tau))
logp = -0.5 * (k * pt.log(2 * np.pi) + quadratic_form) + logdet
logp = -0.5 * (k * pt.log(2 * np.pi) + quadratic_form + logdet)

return check_parameters(
logp,
Expand Down