Skip to content

Fix typos in Doc/extending/extending.rst and Doc/library/shelve.rst #136890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Jul 20, 2025

Focused PR with just the Doc/ changes from #136887


📚 Documentation preview 📚: https://cpython-previews--136890.org.readthedocs.build/

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 20, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jul 20, 2025
@corneliusroemer corneliusroemer changed the title Fix 2 typos in docs using codespell Fix 2 typos in docs Jul 20, 2025
@picnixz picnixz changed the title Fix 2 typos in docs Fix typos in Doc/extending/extending.rst and Doc/library/shelve.rst Jul 21, 2025
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 23, 2025
@serhiy-storchaka serhiy-storchaka merged commit 80a7017 into python:main Jul 23, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jul 23, 2025
@miss-islington-app
Copy link

Thanks @corneliusroemer for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @corneliusroemer and @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 80a7017d2649ad5d7d1f83758eeeef50e5eba6b1 3.14

@miss-islington-app
Copy link

Sorry, @corneliusroemer and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 80a7017d2649ad5d7d1f83758eeeef50e5eba6b1 3.13

brianschubert pushed a commit to brianschubert/cpython that referenced this pull request Aug 3, 2025
…e.rst (pythonGH-136890)

(cherry picked from commit 80a7017)

Co-authored-by: Cornelius Roemer <cornelius.roemer@gmail.com>
brianschubert pushed a commit to brianschubert/cpython that referenced this pull request Aug 3, 2025
…e.rst (pythonGH-136890)

(cherry picked from commit 80a7017)

Co-authored-by: Cornelius Roemer <cornelius.roemer@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 3, 2025

GH-137355 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 3, 2025
@bedevere-app
Copy link

bedevere-app bot commented Aug 6, 2025

GH-137355 is a backport of this pull request to the 3.14 branch.

hugovk added a commit to hugovk/github-tools that referenced this pull request Aug 7, 2025
Fixes:

Checking branch 3.13
From https://github.com/python/cpython
 * [new branch]              3.13       -> 3.13

1 1 10000 python/cpython#136930
  gh-136914: Fix support of cached functions and properties in DocTest's lineno
computation (GH-136930)
    Backport to 3.13 missing
2 1 10000 python/cpython#136890
  Fix typos in Doc/extending/extending.rst and Doc/library/shelve.rst
(GH-136890)
    Backport to 3.13 missing
3 1 10000 python/cpython#136709
  gh-136710: Fix bad indentation in `os.chdir` docstring (GH-136709)
    Backport to 3.13 missing
4 1 10000 python/cpython#136519
  Omit `Python/perf_jit_trampoline.c` from the `**/*jit*` CODEOWNERS rule
(#136519)
fatal: command line, 'Omit `Python/perf_jit_trampoline.c` from the `**/*jit*` CODEOWNERS rule (#136519)': Invalid preceding regular expression
Traceback (most recent call last):
  File "/home/runner/work/dashboard/dashboard/github-tools/needs_backport.py", line 214, in <module>
    main()
    ~~~~^^
  File "/home/runner/work/dashboard/dashboard/github-tools/needs_backport.py", line 170, in main
    candidates = check_prs(
        api, args.repo_path, branch, args.start, args.number, args.sort
    )
  File "/home/runner/work/dashboard/dashboard/github-tools/needs_backport.py", line 109, in check_prs
    if is_commit_title_in_branch(repo_path, title, branch_to_check):
       ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/dashboard/dashboard/github-tools/needs_backport.py", line 60, in is_commit_title_in_branch
    output = subprocess.check_output(
             ~~~~~~~~~~~~~~~~~~~~~~~^
        ["git", "log", "--grep", title, branch], cwd=repo_path
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ).decode("utf-8")
    ^
  File "/opt/hostedtoolcache/Python/3.13.5/x64/lib/python3.13/subprocess.py", line 472, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
           ~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
               **kwargs).stdout
               ^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.13.5/x64/lib/python3.13/subprocess.py", line 577, in run
    raise CalledProcessError(retcode, process.args,
                             output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['git', 'log', '--grep', 'Omit `Python/perf_jit_trampoline.c` from the `**/*jit*` CODEOWNERS rule (#136519)', '3.13']' returned non-zero exit status 128.
@bedevere-app
Copy link

bedevere-app bot commented Aug 8, 2025

GH-137561 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 8, 2025
hugovk pushed a commit to hugovk/cpython that referenced this pull request Aug 8, 2025
…e.rst (pythonGH-136890)

(cherry picked from commit 80a7017)

Co-authored-by: Cornelius Roemer <cornelius.roemer@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 8, 2025

GH-137561 is a backport of this pull request to the 3.13 branch.

hugovk added a commit that referenced this pull request Aug 8, 2025
Co-authored-by: Cornelius Roemer <cornelius.roemer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants