Skip to content

gh-136170: Revert adding ZipFile.data_offset #136950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 21, 2025
+3 −75
Merged

gh-136170: Revert adding ZipFile.data_offset #136950

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8eb63c9
Revert "gh-84481: Make ZipFile.data_offset more robust (#132178)"
emmatyping Jul 21, 2025
4221022
Revert "gh-84481: Add ZipFile.data_offset attribute (#132165)"
emmatyping Jul 21, 2025
c341057
NEWS entry about the removal.
gpshead Jul 21, 2025
8309110
reword news
gpshead Jul 21, 2025
289b7cd
Update Misc/NEWS.d/next/Library/2025-07-21-22-35-50.gh-issue-136170.Q…
picnixz Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reword news
  • Loading branch information
@gpshead
gpshead committed Jul 21, 2025
commit 830911006d4263330387150ae3a9849275f195f1
6 changes: 3 additions & 3 deletions Misc/NEWS.d/next/Library/2025-07-21-22-35-50.gh-issue-136170.QUlc78.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Removed the new in 3.14alpha ``zipfile.ZipFile.data_offset`` property as it
wasn't fully clear which behavior it should have in some situations so the
result was not always what a user might expect.
Removed the unreleased ``zipfile.ZipFile.data_offset`` property added in 3.14a7
as it wasn't fully clear which behavior it should have in some situations so
the result was not always what a user might expect.
Loading