gh-137463: Update validate_abstract_methods in test_collections.py
#137464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for missing abstract methods in `validate_abstract_methods` incorrectly attempted to instantiate the generated class `C` with an argument (`C(name)`), which always raises a `TypeError: C() takes no arguments`. Although the test originally passes, it passes for the wrong reason. This change makes the test correctly validate the enforcement of abstract methods in ABCs.
|
All commit authors signed the Contributor License Agreement. |
This comment was marked as resolved.
This comment was marked as resolved.
sobolevn
approved these changes
Aug 7, 2025
| @@ -963,7 +963,7 @@ class AnextOnly: | |||
| async def __anext__(self): | |||
| raise StopAsyncIteration | |||
| self.assertNotIsInstance(AnextOnly(), AsyncIterator) | |||
| self.validate_abstract_methods(AsyncIterator, '__anext__', '__aiter__') | |||
| self.validate_abstract_methods(AsyncIterator, '__anext__') | |||
There was a problem hiding this comment.
Since AsyncIterator.__aiter__ is not abstract, it is correct to remove it here.
| @@ -1859,7 +1858,7 @@ def test_MutableMapping(self): | |||
| for sample in [dict]: | |||
| self.assertIsInstance(sample(), MutableMapping) | |||
| self.assertIsSubclass(sample, MutableMapping) | |||
| self.validate_abstract_methods(MutableMapping, '__contains__', '__iter__', '__len__', | |||
| self.validate_abstract_methods(MutableMapping, '__iter__', '__len__', | |||
There was a problem hiding this comment.
__contains__ is also not abstract, except for Container.__contains__
| @@ -1954,8 +1952,8 @@ def test_MutableSequence(self): | |||
| self.assertIsSubclass(sample, MutableSequence) | |||
| self.assertIsSubclass(array.array, MutableSequence) | |||
| self.assertNotIsSubclass(str, MutableSequence) | |||
| self.validate_abstract_methods(MutableSequence, '__contains__', '__iter__', | |||
| '__len__', '__getitem__', '__setitem__', '__delitem__', 'insert') | |||
| self.validate_abstract_methods(MutableSequence, '__len__', '__getitem__', | |||
There was a problem hiding this comment.
And __iter__ here is also not abstract.
|
Thanks @guilhermeleobas for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 7, 2025
…ons.py` (pythonGH-137464) Update `validate_abstract_methods` in `test_collections.py` The test for missing abstract methods in `validate_abstract_methods` incorrectly attempted to instantiate the generated class `C` with an argument (`C(name)`), which always raises a `TypeError: C() takes no arguments`. Although the test originally passes, it passes for the wrong reason. This change makes the test correctly validate the enforcement of abstract methods in ABCs. (cherry picked from commit 5be8723) Co-authored-by: Guilherme Leobas <guilhermeleobas@gmail.com>
|
Sorry, @guilhermeleobas and @sobolevn, I could not cleanly backport this to |
|
GH-137503 is a backport of this pull request to the 3.14 branch. |
|
@guilhermeleobas can you please do the manual backport to 3.13? :) |
|
Sure! Thanks for the review. |
|
GH-137516 is a backport of this pull request to the 3.13 branch. |
|
GH-137521 is a backport of this pull request to the 3.13 branch. |
guilhermeleobas
added a commit
to guilhermeleobas/cpython
that referenced
this pull request
Aug 7, 2025
…ons.py` (python#137464) Update `validate_abstract_methods` in `test_collections.py` The test for missing abstract methods in `validate_abstract_methods` incorrectly attempted to instantiate the generated class `C` with an argument (`C(name)`), which always raises a `TypeError: C() takes no arguments`. Although the test originally passes, it passes for the wrong reason. This change makes the test correctly validate the enforcement of abstract methods in ABCs. (cherry picked from commit 5be8723)
sobolevn
pushed a commit
that referenced
this pull request
Aug 7, 2025
…s.py (GH-137464) (#137521) gh-137463: Update `validate_abstract_methods` in `test_collections.py` (#137464) Update `validate_abstract_methods` in `test_collections.py` The test for missing abstract methods in `validate_abstract_methods` incorrectly attempted to instantiate the generated class `C` with an argument (`C(name)`), which always raises a `TypeError: C() takes no arguments`. Although the test originally passes, it passes for the wrong reason. This change makes the test correctly validate the enforcement of abstract methods in ABCs. (cherry picked from commit 5be8723)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for missing abstract methods in
validate_abstract_methodsincorrectly attempted to instantiate the generated classCwith an argument (C(name)), which always raises aTypeError: C() takes no arguments. Although the test originally passes, it passes for the wrong reason.This change makes the test correctly validate the enforcement of abstract methods in ABCs.