Skip to content

gh-137205: Document how to safely use PRAGMA during SQLite transactions #137505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

gh-137205: Document how to safely use PRAGMA during SQLite transactions #137505

wants to merge 9 commits into from
+55 −7

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 7, 2025 •
edited by github-actions bot
Loading

@erlend-aasland erlend-aasland added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 7, 2025
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Aug 7, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Aug 7, 2025
@bedevere-app bedevere-app bot mentioned this pull request Aug 7, 2025
Open
erlend-aasland
erlend-aasland commented Aug 7, 2025
View reviewed changes
StanFromIreland
StanFromIreland reviewed Aug 7, 2025
View reviewed changes
erlend-aasland and others added 2 commits August 7, 2025 10:08
@erlend-aasland @StanFromIreland
Add missing semicolon to seealso
5ef2d72 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@erlend-aasland
Correctly setup and format example doctest code
155013f
@erlend-aasland erlend-aasland marked this pull request as ready for review August 7, 2025 09:01
@erlend-aasland erlend-aasland moved this from Todo to In Progress in Docs PRs Aug 7, 2025
StanFromIreland
StanFromIreland approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

PS. You may have accidentally added the 3.12 back port label.

@erlend-aasland
Copy link
Contributor Author

Looks fine to me.

Thanks for the review.

PS. You may have accidentally added the 3.12 back port label.

autocommit was added in 3.12; I prefer to also amend the 3.12 docs.

@zzzeek: would you like to review this?

@erlend-aasland
Copy link
Contributor Author

I made some amendments:

@erlend-aasland
Copy link
Contributor Author

cc. @layday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
awaiting core review docs Documentation in the Doc dir needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news
Projects
Docs PRs
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erlend-aasland @StanFromIreland