gh-137526: Fix broken link to drdobbs journal in difflib.rst #137527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
approved these changes
Aug 7, 2025
There was a problem hiding this comment.
The wayback machine article works, but the code formatting is quite poor.
A
|
Usually archive.org link is better. In this case, I reviewed the archived link and it seems to be better. |
|
Thanks @s3bw for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 7, 2025
…ythonGH-137527) (cherry picked from commit 244c7b8) Co-authored-by: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 7, 2025
…ythonGH-137527) (cherry picked from commit 244c7b8) Co-authored-by: Sebastien Williams-Wynn <s.williamswynn.mail@gmail.com>
|
GH-137531 is a backport of this pull request to the 3.14 branch. |
|
GH-137532 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve updated the broken link, it now links to a version of the page that is being hosted by an amateur archivist. (This was done after looking for a surviving link via web.archive).
Much later I found this link: https://web.archive.org/web/20071216020031/http://www.ddj.com/184407970?pgno=5 however I've kept the link to https://jacobfilipp.com/DrDobbs/ as it's more navigable than the web archive.
Since the journal doesn’t exist there are 4 options for the second link.
I went with 3.
Here’s a post by the archivist on the EOL of DDJ: https://jacobfilipp.com/thedoctor/
Another solution is removing the “See Also” block completely.
📚 Documentation preview 📚: https://cpython-previews--137527.org.readthedocs.build/