-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
GH-137630: Convert _interpreters
to use Argument Clinic
#137631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AA-Turner
wants to merge
27
commits into
python:main
Choose a base branch
from
AA-Turner:clinic/_interpretersmodule
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
5997f18
Convert _interpreters.create()
AA-Turner 4b159b3
Convert _interpreters.destroy()
AA-Turner eda5fa0
Convert _interpreters.list_all()
AA-Turner 699dc6d
Convert _interpreters.get_current()
AA-Turner c313b80
Convert _interpreters.get_main()
AA-Turner abe7aaa
Convert _interpreters.set___main___attrs()
AA-Turner 6903b3f
Convert _interpreters.exec()
AA-Turner d0b2e8d
Convert _interpreters.run_string()
AA-Turner 91d15b5
Convert _interpreters.run_func()
AA-Turner 98a75b2
Convert _interpreters.call()
AA-Turner 6d863cb
Convert _interpreters.is_shareable()
AA-Turner 84217c8
Convert _interpreters.is_running()
AA-Turner bfed2bf
Convert _interpreters.get_config()
AA-Turner 599bde4
Convert _interpreters.whence()
AA-Turner 20c67ee
Convert _interpreters.incref()
AA-Turner b7a49d3
Convert _interpreters.decref()
AA-Turner d07daae
Convert _interpreters.capture_exception()
AA-Turner 9e5577e
Add note on new_config()
AA-Turner eb21bb1
Indicate positional-only parameters
AA-Turner 6e26591
Update docstrings
AA-Turner 08dce29
Update tests
AA-Turner af65824
Blurb
AA-Turner 435389f
make regen-all
AA-Turner be2fe07
Fix new_config_doc
AA-Turner 073e2ff
Undo docstring changes
AA-Turner 1cdf313
Revert "Indicate positional-only parameters"
AA-Turner e8f0b6c
Serhiy's review
AA-Turner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "Indicate positional-only parameters"
This reverts commit eb21bb1
- Loading branch information
commit 1cdf313021bbeb524887e9cbe0ca83215ed986e5
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the default value
None
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the docstring, "The default is 'isolated'.". I think showing this is more helpful than
None
, what do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the code the default is equivalent to None. I did not look deeper. @ericsnowcurrently?