Skip to content

Remove duplicate get_external_apt_dependencies.py and re-standardize CI package install logs #14533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Aug 6, 2025

CC @srittau I noticed that the script you added in #13976 is actually just a duplicate of get_stubtest_system_requirements.py but that only works on linux. Calling the existing get_stubtest_system_requirements.py instead would've worked the same.

I also:

  • standardized using $DEPENDENCIES vs $PACKAGES as a variable name in the CI scripts to make more of the scripts identical.
  • added packages list print to daily tests.
  • noticed you improved the packages list print, so I reused what you did there.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old script doesn't deduplicate and sort dependencies. We should change that before merging this, but LGTM otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants