-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[stdlib] Deprecate old functions #14553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is great! I really like that you took care to only add @deprecated
for the Python versions where APIs actually caused a deprecation warning to be emitted at runtime. Just some nits about error messages:
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you for review |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Next deprecations were found using grep
version_info <
and only if somewhere in docs or source code it was said that it was deprecated, I would add the@deprecated
:tkinter
split() method cpython#28237PS: I just want to clarify that I’m not aiming to mark every deprecated function, only the ones that seem most obvious. Also, for functions deprecated since 3.10, I don’t feel that adding sys.version_info check is necessary.