Skip to content

[stdlib] Deprecate old functions #14553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 10, 2025

Conversation

donBarbos
Copy link
Contributor

@donBarbos donBarbos commented Aug 10, 2025

Next deprecations were found using grep version_info < and only if somewhere in docs or source code it was said that it was deprecated, I would add the @deprecated:

PS: I just want to clarify that I’m not aiming to mark every deprecated function, only the ones that seem most obvious. Also, for functions deprecated since 3.10, I don’t feel that adding sys.version_info check is necessary.

@donBarbos donBarbos changed the title [stdlib] Deprecate many functions [stdlib] Deprecate old functions Aug 10, 2025

This comment has been minimized.

@donBarbos donBarbos marked this pull request as ready for review August 10, 2025 17:49

This comment has been minimized.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great! I really like that you took care to only add @deprecated for the Python versions where APIs actually caused a deprecation warning to be emitted at runtime. Just some nits about error messages:

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@donBarbos
Copy link
Contributor Author

Thank you for review

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit fb0940e into python:main Aug 10, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants