Skip to content

Remove pip caching for Windows #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

Remove pip caching for Windows #3313

merged 1 commit into from
Aug 5, 2025

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Aug 5, 2025 •
edited
Loading

I've suffered through one too many CI failures due to pip's caching being wrong...

For CPython 3.11, this adds 18 seconds:

  Prepared 61 packages in 18.10s

CoolCat467
CoolCat467 approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@CoolCat467 CoolCat467 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, while caching is a nice idea in theory, in practice it tends to lead to unnecessary hardship and the benefits aren't really worth the flakiness.

@jakkdl jakkdl merged commit 7f7bf5e into python-trio:main Aug 5, 2025
46 checks passed
@A5rocks A5rocks deleted the no-more-cache branch August 5, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoolCat467 CoolCat467 CoolCat467 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@A5rocks @CoolCat467 @jakkdl