Skip to content

Delete Python reference implementation from torchdim, as it is untested #160115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Delete Python reference implementation from torchdim, as it is untested #160115

wants to merge 5 commits into from
+15 −909

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Aug 7, 2025 •
edited
Loading

@ezyang
Update
0893f63 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160115

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 11ba7fa with merge base d3d359d (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Aug 7, 2025
@ezyang
Delete Python reference implementation from torchdim, as it is untested
29daebf 
Signed-off-by: Edward Yang <ezyang@meta.com>
ghstack-source-id: 6a20def
Pull-Request: #160115
@ezyang ezyang mentioned this pull request Aug 7, 2025
Closed
albanD
albanD reviewed Aug 7, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this folder should be cleaned up tbh. Everything important was moved to torch/ already.

@ezyang
Update
e5f38d1 
[ghstack-poisoned]
ezyang added a commit that referenced this pull request Aug 8, 2025
@ezyang
Delete Python reference implementation from torchdim, as it is untested
14ebb94 
Signed-off-by: Edward Yang <ezyang@meta.com>
ghstack-source-id: 8858f38
Pull-Request: #160115
@ezyang
Update
68da4ac 
[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Aug 9, 2025
Open
@ezyang ezyang added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Aug 9, 2025
@ezyang
Update
8c62463 
[ghstack-poisoned]
@ezyang ezyang added the topic: not user facing topic category label Aug 9, 2025
ezyang added a commit that referenced this pull request Aug 9, 2025
@ezyang
Delete Python reference implementation from torchdim, as it is untested
4758195 
Signed-off-by: Edward Yang <ezyang@meta.com>
ghstack-source-id: 4602822
Pull-Request: #160115
@ezyang ezyang mentioned this pull request Aug 9, 2025
Open
@ezyang
Copy link
Contributor Author

ezyang commented Aug 10, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 10, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ezyang
Update
11ba7fa 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Aug 10, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezyang @pytorchmergebot @albanD