Skip to content

Fix clang builds by adding headers #160252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix clang builds by adding headers #160252

wants to merge 2 commits into from

Conversation

tanmay-sinha
Copy link
Contributor

@tanmay-sinha tanmay-sinha commented Aug 9, 2025 •
edited by pytorch-bot bot
Loading

Clang compiler from llvm-14 fails to build full torch from source with the message

no template named 'unordered_map' in namespace 'std'
  std::unordered_map<std::string, HandlerFunc> handlers_{};
 ~~~~~^

A similar issue here intel/llvm#5264
Fix is to add the correct headers.

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta

@tanmay-sinha
Fix clang builds by adding headers
d37a857 
Clang build fails with the message 
no template named 'unordered_map' in namespace 'std'
  std::unordered_map.
A similar issue here intel/llvm#5264
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160252

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 54 Pending

As of commit 7c2dc02 with merge base 1c2cba1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 9, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Aug 9, 2025
@tanmay-sinha tanmay-sinha marked this pull request as ready for review August 9, 2025 17:20
@tanmay-sinha
Copy link
Contributor Author

@Skylion007 When do we merge the PRs? Are there any specific timelines? Sorry to ask this but I am new to this.

@cyyever
Copy link
Collaborator

cyyever commented Aug 11, 2025

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 11, 2025
@cyyever
Copy link
Collaborator

cyyever commented Aug 11, 2025

@tanmay-sinha Self-help on an approved PR.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever
Copy link
Collaborator

cyyever commented Aug 11, 2025

@pytorchmergebot merge -f "It builds"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@cyyever cyyever cyyever approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (c10d) release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tanmay-sinha @cyyever @pytorchmergebot @Skylion007 @pytorchbot