Skip to content

[inductor] Windows inductor use intel-openmp. #160258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[inductor] Windows inductor use intel-openmp. #160258

wants to merge 4 commits into from
+13 −6

Conversation

xuhancn
Copy link
Collaborator

@xuhancn xuhancn commented Aug 9, 2025 •
edited
Loading

After some debug work, I found PyTorch torch_cpu.dll is using intel-openmp, but not MSVC openmp.
So, switch Windows inductor to intel-openmp.

It fixed:

pytorch/test/inductor/test_aot_inductor.py

Lines 2405 to 2408 in c8205cb

@skipIfWindows(
msg="OpenMP crashed application on windows"
) # TODO: (xuhancn) need to root cause and fix.
def test_buffer_mutation_3(self):

image

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

@xuhancn xuhancn added module: windows Windows support for PyTorch ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category intel This tag is for PR from Intel labels Aug 9, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160258

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b1df98b with merge base 4416433 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@xuhancn xuhancn force-pushed the xu_win_inductor_use_intel_openmp branch from 58ee712 to 680d20d Compare August 10, 2025 00:47
@xuhancn
Copy link
Collaborator Author

xuhancn commented Aug 10, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased xu_win_inductor_use_intel_openmp onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout xu_win_inductor_use_intel_openmp && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the xu_win_inductor_use_intel_openmp branch from dab7ff8 to bb0f5ba Compare August 10, 2025 03:26
@xuhancn
Copy link
Collaborator Author

xuhancn commented Aug 10, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased xu_win_inductor_use_intel_openmp onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout xu_win_inductor_use_intel_openmp && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the xu_win_inductor_use_intel_openmp branch from 5ad65c8 to b9fc55a Compare August 10, 2025 14:24
@xuhancn
Copy link
Collaborator Author

xuhancn commented Aug 10, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased xu_win_inductor_use_intel_openmp onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout xu_win_inductor_use_intel_openmp && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the xu_win_inductor_use_intel_openmp branch from b9fc55a to b1df98b Compare August 10, 2025 23:31
@xuhancn xuhancn marked this pull request as ready for review August 11, 2025 06:03
@xuhancn xuhancn requested review from ezyang, jansel and angelayi August 11, 2025 06:03
angelayi
angelayi reviewed Aug 12, 2025
View reviewed changes
setup.py
@@ -1615,6 +1615,7 @@ def main() -> None:
"networkx>=2.5.1",
"jinja2",
"fsspec>=0.8.5",
'intel-openmp==2025.1.1 ;platform_system == "Windows" ', # for Windows inductor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ok to add? cc @malfet

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet please take a look.

@xuhancn xuhancn requested a review from malfet August 12, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelayi angelayi angelayi left review comments

@ezyang ezyang Awaiting requested review from ezyang

@jansel jansel Awaiting requested review from jansel

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request intel This tag is for PR from Intel module: inductor module: windows Windows support for PyTorch open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xuhancn @pytorchmergebot @angelayi @pytorchbot