[FSDP2] cast unsharded_param_grad
to correct reduce dtype
#160279
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an edge case when using gradient accumulation steps with FSDP2.
If a parameter within a parameter group doesnt have gradients for all but the final backwards pass, the grad is not casted to the reduce dtype resulting in inconsistent dtype between gradients for
reduce_scatter
.Specifically, if using a MixedPrecisionPolicy with
param_dtype=torch.bfloat16
andreduce_dtype=torch.float32
, parameters that had grads for both steps will have gradients of dtype torch.float32, but those that have a gradient only on the final pass will have gradients of dtype torch.bfloat16. This raises:This pr explicitly casts the grad to the correct dtype for the given case.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta