Skip to content

Reworked Autocomplete, fixed dropdown issues #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from

Conversation

vitalif
Copy link

@vitalif vitalif commented Aug 12, 2018

Hi!

Thanks for your library, I like it very much.
However it has several issues with autocomplete. Most (I hope all) of them is fixed in my version.
Features:

  • Clearable dropdown & autocomplete
  • Autocomplete rendering in Portal
  • Simplified Autocomplete code
  • Fixed onFocus/onBlur issues with dropdowns
  • Always controlled Inputs

Basically I think I've done at least some part of #1169

I may split out autocomplete and other fixes in separate commits/PRs if you want. Also it's probably missing docs. But first I want to submit the pull request so you can check it out...:)

@vitalif vitalif force-pushed the dev branch 3 times, most recently from 5f4284c to 1fde176 Compare December 18, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant