Fixed issue of scrollbar being hidden on Autocomplete and Dropdown components #1885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut based on Material Spec. (react-toolbox#1187) https://material.io/guidelines/components/text-fields.html#text-fields-s ingle-line-text-field
* Fixed react-toolbox#894 by adding a disableScrolling prop * Fixing scroll style
…ops are changed, instead of in shouldComponentUpdate (react-toolbox#1327)
Without type="button", the tab buttons default to submitting any html form which contains them.
…milar as other components react-toolbox#1544
Adding Event to be passed for Radio Group for handleClick function similar as other components react-toolbox#1544
Replaced tab label with button element for keyboard accessibility. (v1.3.4)
… consistent with the arguments passed to onChange handlers by the DOM
…ts-passed-to-onchange-handlers document the arguments passed to onChange props, because they are not consistent with the arguments passed to onChange handlers by the DOM
|
Hello @paddotk! Thank you for your contribution! There are some conflicts with the css files, since we've renamed them to |
|
@rubenmoya Pushed an update. I got many merge conflicts, but not with the css files though. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropdown and Autocomplete components had a
width: 0andheight: 0css rules. These don't serve any purpose and make users not know it's scrollable/there is more content, hence is bad user experience.This fix takes out the two css lines to show scrollbar whenever necessary.