Fix for jumping Calendar Heatmap #291
Conversation
✅ Deploy Preview for reaviz-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| @@ -73,7 +74,17 @@ export const LinearAxis: FC<Partial<LinearAxisProps>> = (props) => { | |||
| width: width | |||
| }); | |||
|
|
|||
| // Use a ref to track update count to prevent infinite loops | |||
| const updateCountRef = useRef(0); | |||
There was a problem hiding this comment.
This feels like a odd way to fix it. Whats triggering this to go in a loop?
There was a problem hiding this comment.
useEffect from line 111 and onDimensionsChange
There was a problem hiding this comment.
Makes sense but I'm curious what in the heatmap that could be causing this since it seems unique to the heatmap since other charts i've not seen this one.
There was a problem hiding this comment.
Pull Request Overview
This PR adds loop prevention logic to the LinearAxis component to fix the jumping behavior by throttling repeated dimension updates.
- Introduces a
useRefcounter to guard against excessiveupdateDimensionscalls - Adds reset logic when dependencies change to restart the count for each render cycle
|
I’ve changed the approach for this fix: now we use a |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
bug.mov
What is the new behavior?
No more jumping behavior
Does this PR introduce a breaking change?
Other information