-
Notifications
You must be signed in to change notification settings - Fork 143
Update the auto YAML Generation #7725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
royendo
wants to merge
34
commits into
main
Choose a base branch
from
docs/auto-gen-YAML
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
1df036d
some changes for connector YAML
royendo 3ff888e
remove
royendo a381593
separated YAML schema
royendo b6b987f
nit
royendo d7d4b11
link fixes
royendo a3784a0
Update generate_project.go
royendo f2ed2c4
add sec warning
royendo d57d430
motherduck live connector
royendo e5434ee
remove local file from connector
royendo cd0c819
nit
royendo d3396eb
matching file names
royendo 16c99c6
reordered files and added sources YAML and model SQL
royendo 6ba0dcd
nit, fix links
royendo 4363fff
comparing with current YAML changes
royendo 64677e0
Merge branch 'main' into docs/auto-gen-YAML
royendo 77f0ca9
adding annotatons back
royendo 7c35559
gofmt, golint
royendo 0ff11e2
fix
royendo 11b2710
first pass fix, need to review a few other items
royendo db75a6b
remove toplevel driver
royendo 95ca49a
single project file
royendo 98baf56
Update generate_project.go
royendo 7065bcc
good old cursor wiped my functoni
royendo dba395a
missing parameters
royendo 6e32ddd
midding parameters and inline examples
royendo c55eff3
god so many false positives from asking cursor to merge files
royendo 6ffe7f8
adding links
royendo f69c89a
fixed oneOf
royendo 3b6517e
split data properties to have api excamples
royendo e67f159
gonig through files
royendo df54d71
returning original format
royendo f94396e
?
royendo c58c634
Merge remote-tracking branch 'origin/main' into docs/auto-gen-YAML
royendo e8c04e9
fixing urls,
royendo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
split data properties to have api excamples
- Loading branch information
commit 3b6517e6e5b05de5ad3f0dfb5e568ac7e5905166
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,50 +45,22 @@ _[string]_ - Description for the alert | |
_[oneOf]_ - Data source for the alert _(required)_ | ||
|
||
- **option 1** - _[object]_ - Executes a raw SQL query against the project's data models. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here. we should not remove options. |
||
```yaml | ||
type: api | ||
|
||
connector: "duckdb" | ||
sql: "SELECT * FROM user_metrics WHERE date >= '2024-01-01'" | ||
``` | ||
|
||
|
||
- **`sql`** - _[string]_ - Raw SQL query to run against existing models in the project. _(required)_ | ||
|
||
- **`connector`** - _[string]_ - specifies the connector to use when running SQL or glob queries. | ||
|
||
- **option 2** - _[object]_ - Executes a SQL query that targets a defined metrics view. | ||
```yaml | ||
type: api | ||
|
||
metrics_sql: "SELECT * FROM user_metrics WHERE date >= '2024-01-01'" | ||
``` | ||
|
||
|
||
- **`metrics_sql`** - _[string]_ - SQL query that targets a metrics view in the project _(required)_ | ||
|
||
- **option 3** - _[object]_ - Calls a custom API defined in the project to compute data. | ||
```yaml | ||
type: api | ||
|
||
api: "user_analytics_api" | ||
args: | ||
start_date: "2024-01-01" | ||
limit: 10 | ||
``` | ||
|
||
|
||
- **`api`** - _[string]_ - Name of a custom API defined in the project. _(required)_ | ||
|
||
- **`args`** - _[object]_ - Arguments to pass to the custom API. | ||
|
||
- **option 4** - _[object]_ - Uses a file-matching pattern (glob) to query data from a connector. | ||
```yaml | ||
type: api | ||
|
||
glob: "data/*.csv" | ||
``` | ||
|
||
|
||
- **`glob`** - _[anyOf]_ - Defines the file path or pattern to query from the specified connector. _(required)_ | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we remove the options? I think it was clearer before, as it showed that the user could choose any option like sql, metric_sql, api, etc.