Skip to content

Implement mode readwrite for Motherduck and DuckLake #7735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

grahamplata
Copy link
Contributor

@grahamplata grahamplata commented Aug 5, 2025

Implement mode: readwrite for MotherDuck and DuckLake

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@grahamplata grahamplata marked this pull request as ready for review August 7, 2025 18:33
@grahamplata grahamplata self-assigned this Aug 7, 2025
@@ -127,6 +127,16 @@ var motherduckSpec = drivers.Spec{
Placeholder: "my_new_source",
Required: true,
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be part of config properties and not source properties. The source properties apply when we are creating a source that extracts data from motherduck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants