Skip to content

Update rustfmt's dependency on term to 1.1 #145118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update rustfmt's dependency on term to 1.1 #145118

wants to merge 1 commit into from

Conversation

dpaoliello
Copy link
Contributor

term 0.7 depends on winapi, which is an old, unsupported crate for Windows bindings and (for my purposes) doesn't fully support Arm64EC.

This change updates term to 1.1, which now uses windows-sys 0.60.2 (which Rust already depends on).

@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

@klensy
Copy link
Contributor

klensy commented Aug 8, 2025

Feels like rustfmt diverges more and more from its own repo version.

@dpaoliello
Copy link
Contributor Author

Feels like rustfmt diverges more and more from its own repo version.

Ah, I didn't realize that rustfmt has its own repo.
Should I submit this upstream, and then it can be synced back (along with the annotate-snippets change)?

@klensy
Copy link
Contributor

klensy commented Aug 8, 2025

Ofc you can submit upstream, but when it will be synced back - depends on maintainer.

@dpaoliello
Copy link
Contributor Author

Abandoning in favor of rust-lang/rustfmt#6628

@dpaoliello dpaoliello closed this Aug 8, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2025
@dpaoliello dpaoliello deleted the term1.1 branch August 8, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dpaoliello @rustbot @klensy @Mark-Simulacrum