Skip to content

Fix fewest modules OOM #4986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Fix fewest modules OOM #4986

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
88e77d4
Fix #4985: Create separate tagger for FewestModules
steinybot May 20, 2024
7fbe85e
Fix #4985: Tag FewestModules breadth first
steinybot May 20, 2024
3078fac
Fix #4985: Fix transitive static dependencies
steinybot May 20, 2024
310469b
Fix #4985: Fix docs
steinybot May 20, 2024
1644a97
Fix #4985: Combine taggers again
steinybot May 21, 2024
c134cf8
Fix #4985: Update docs
steinybot May 21, 2024
a86e07e
Fix #4985: Update docs
steinybot May 21, 2024
96036ad
Fix #4985: Remove bogus tests
steinybot May 21, 2024
4fdba31
Skip calculating excluded hops for fewest modules
steinybot May 22, 2024
bdfe51f
Add missing exclusion check back in
steinybot May 22, 2024
db851c4
Fix excluded hop counts
steinybot May 22, 2024
b7d9577
Fix revisting static dependencies
steinybot May 22, 2024
f72c81a
Update comment
steinybot May 22, 2024
e47f9d5
Add tests
steinybot May 23, 2024
92d63b5
Update comment
steinybot May 23, 2024
bf0d159
Remove trailing commas
steinybot Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comment
  • Loading branch information
@steinybot
steinybot committed May 23, 2024
commit 92d63b58f995b712f11bbf4ff3555b9931d02f41
5 changes: 2 additions & 3 deletions linker/shared/src/main/scala/org/scalajs/linker/frontend/modulesplitter/Tagger.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,8 @@ private class Tagger(infos: ModuleAnalyzer.DependencyInfo,
val nextClassNames =
if (moduleIDChanged) {
// Revisit static dependencies again when the module id changes.
// We do not need to revisit dynamic dependencies because by definition they are not used by public
// modules, the first time we tag them is the shortest path so that path end never changes and only the
// ends are used for the module ids.
// We do not need to revisit dynamic dependencies because their module id only changes when there is a
// new usage which is the case above and there we already revisit them.
classNames.tail ++ infos.classDependencies(className).staticDependencies
} else {
// Otherwise do not consider dependencies again as there is no more information to find.
Expand Down