WiP Redesign the encoding of Longs in JavaScript + GCC v20240317 (JDK 17+). #5216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a nice bonus, the IR checker now passes with `RuntimeLong`.
Sadly, that doesn't fix the GCC issue. It may have performance, especially in multi-module outputs, as we don't need to mutate a foreign var.
This fixes the issue where GCC breaks the output of the new expanded RuntimeLongs.
ded9630 to
d6fcbb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly to test that upgrading GCC actually fixes the issue and doesn't break anything else.
The requirement on JDK 17+ makes this a bit of a non-starter at this point. However, since Scala 3 is about to drop support under JDK 17, we might have a chance to do this in the coming ~year.