-
Notifications
You must be signed in to change notification settings - Fork 19
Update dependency babel-plugin-ember-template-compilation to v3 #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update dependency babel-plugin-ember-template-compilation to v3 #1292
Conversation
|
@@ -22,7 +22,7 @@ import ember from 'eslint-plugin-ember/recommended'; | |||
import prettier from 'eslint-plugin-prettier/recommended'; | |||
import n from 'eslint-plugin-n'; | |||
|
|||
import babelParser from '@babel/eslint-parser'; | |||
import babelParser from '@babel/eslint-parser/experimental-worker'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we could wait for this worker to become stable before we upgrade the Ember plugin. I think it's fine to use this, seems to be working well.
babel-plugin-ember-template-compilation@v3 is ESM, which is only supported in the experimental worker for babel/eslint-parser (for now). There was also a bug in older versions where an async config threw an error. Upgrading babel dependencies fixes that error.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
85c2dd6
to
e657426
Compare
|
This PR contains the following updates:
2.4.1
->3.0.0
Release Notes
emberjs/babel-plugin-ember-template-compilation (babel-plugin-ember-template-compilation)
v3.0.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.