fix: range subselect alias pointer dereference #3711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The third item in your list is unrelated, but the other two are valid. I will attempt to add some tests to your branch so that we can evaluate and merge. |
1522758 to
8e48e5d
Compare
kyleconroy
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made to solve dereference panics reported by a list of open issues (I've also seen it in my codebase):
Queries and schemas combined below, none of which panic anymore on this branch.
https://play.sqlc.dev/p/f1541063c62ed9302d43b7d00eec0d487764e5ee577a43e4114ff6c654585768