Skip to content

Update +error.svelte creation template in vscode extension #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

olegpolin
Copy link

Fixes #2810

@dummdidumm
Copy link
Member

We have to check which version of Svelte/SvelteKit people use since this will only work when you're using a sufficiently new version of both

@olegpolin
Copy link
Author

We have to check which version of Svelte/SvelteKit people use since this will only work when you're using a sufficiently new version of both

Thanks, added the different variants

@olegpolin
Copy link
Author

@dummdidumm is it fine now?

@jasonlyu123
Copy link
Member

Can you add a flag similar to the withProps used in layout.ts and page.ts? So that it only shows in SvelteKit 2.12 and above.

@olegpolin olegpolin deleted the branch sveltejs:master August 11, 2025 13:06
@olegpolin olegpolin closed this Aug 11, 2025
@olegpolin olegpolin deleted the master branch August 11, 2025 13:06
@olegpolin olegpolin restored the master branch August 11, 2025 13:06
@olegpolin
Copy link
Author

olegpolin commented Aug 11, 2025

Oops misclick, sorry

@olegpolin olegpolin reopened this Aug 11, 2025
@olegpolin olegpolin deleted the branch sveltejs:master August 11, 2025 13:07
@olegpolin olegpolin closed this Aug 11, 2025
@olegpolin olegpolin deleted the master branch August 11, 2025 13:07
@olegpolin olegpolin restored the master branch August 11, 2025 13:07
@olegpolin olegpolin reopened this Aug 11, 2025
@olegpolin
Copy link
Author

@jasonlyu123 So should withRunes be changed to withProps? Since withProps without withRunes is impossible and the +error.svelte template doesn't use props?

@jasonlyu123
Copy link
Member

I meant to add a new withAppState option. The withProps option is for the PageData => PageProps migration, similar to the $app/store to $app/state migration.

@olegpolin
Copy link
Author

Got it, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

+error.svelte page creation in vscode from template uses outdated syntax
3 participants