bug #61056 [Validator] Allow mixed root on CompoundConstraintTestCase validator (thePanz)

nicolas-grekas · nicolas-grekas · commit e88263c50ec8 · 2025-07-09T11:36:23.000+02:00
This PR was merged into the 7.2 branch. Discussion ---------- [Validator] Allow mixed root on `CompoundConstraintTestCase` validator | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT The CompoundConstraintTestCase is currently defining a `protected string $root`, forcing the root to be a "string". Testing compound constraints where the root is something different is triggering Static-Analysis (phpstan) warings or (worst) casting the `$root` to a string, causing PHP errors. In the given code: the `$root` is passed to the ExecutionContext, which has the following constructor signature: `__construct(private ValidatorInterface $validator, private mixed $root, private TranslatorInterface $translator, ...)`, thus `mixed` can be safely used in the `CompoundConstraintTestCase` class too. Commits ------- 47b5387 Allow mixed root on CompoundConstraintTestCase validator
diff --git a/src/Symfony/Component/Validator/Test/CompoundConstraintTestCase.php b/src/Symfony/Component/Validator/Test/CompoundConstraintTestCase.php
@@ -35,7 +35,7 @@ abstract class CompoundConstraintTestCase extends TestCase
     protected ValidatorInterface $validator;
     protected ?ConstraintViolationListInterface $violationList = null;
     protected ExecutionContextInterface $context;
-    protected string $root;
+    protected mixed $root;
 
     private mixed $validatedValue;
 
