Fix wrong boolean values #61296
Merged
Fix wrong boolean values #61296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Aug 1, 2025
| @@ -2141,7 +2141,7 @@ public function testMoney() | |||
| public function testMoneyWithoutCurrency() | |||
| { | |||
| $form = $this->factory->createNamed('name', 'Symfony\Component\Form\Extension\Core\Type\MoneyType', 1234.56, [ | |||
| 'currency' => false, | |||
| 'currency' => null, | |||
There was a problem hiding this comment.
Passing false is actually what is documented as the way to suppress showing the currency symbol:
You can also set this to false to hide the currency symbol.
see https://symfony.com/doc/current/reference/forms/types/money.html#currency
There was a problem hiding this comment.
Well I'm not sure if this a documentation issue or a core bug where the field type should be widened
OskarStark
reviewed
Aug 1, 2025
| @@ -1386,7 +1385,6 @@ public function testNormalizerCanAccessLazyOptions() | |||
| $this->resolver->setDefault('norm', 'baz'); | |||
|
|
|||
| $this->resolver->setNormalizer('norm', function (Options $options) { | |||
| /** @var TestCase $test */ | |||
| Assert::assertEquals('bar', $options['lazy']); | |||
There was a problem hiding this comment.
Suggested change
| Assert::assertEquals('bar', $options['lazy']); | |
| Assert::assertSame('bar', $options['lazy']); |
?
OskarStark
reviewed
Aug 1, 2025
Comment on lines
+2418
to
+2420
| $this->assertTrue($this->resolver->isDefined('foo')); | ||
| $this->assertTrue($this->resolver->isDeprecated('foo')); | ||
| $this->assertTrue($this->resolver->hasDefault('foo')); |
2adde56 to
12d0aa9
Compare
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Aug 5, 2025
This slipped in with symfony#61296. Technically, there shouldn't be a difference but since we explicitly mention false in the documentation let's better be safe here.
nicolas-grekas
added a commit
that referenced
this pull request
Aug 5, 2025
…y symbol (xabbuh) This PR was merged into the 6.4 branch. Discussion ---------- [Form] use `false` instead of `null` to hide the currency symbol | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT This slipped in with #61296. Technically, there shouldn't be a difference but since we explicitly mention false in the documentation let's better be safe here. Commits ------- ecd674d use false instead of null to hide the currency symbol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subset of #61203 that's obviously mistakes