Skip to content

[Validator] (60455) Validate translations for Arabic (ar) #61354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

Zouaoui-Montassar
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #60455
License MIT

Description

I have reviewed the arabic translation for the id="121" and confirmed that it is accurate.
The text remains unchanged, and the state="needs-review-translation" has been removed.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot

This comment was marked as outdated.

@Zouaoui-Montassar Zouaoui-Montassar changed the base branch from 7.4 to 6.4 August 7, 2025 10:04
@Zouaoui-Montassar
Copy link
Contributor Author

Could someone please update the milestone to 6.4? I mistakenly selected 7.4 when creating the PR, even though the base branch is correctly set to 6.4. The milestone was added automatically by @carsonbot.

@GromNaN GromNaN modified the milestones: 7.4, 6.4 Aug 7, 2025
@GromNaN
Copy link
Member

GromNaN commented Aug 7, 2025

Thank you @Zouaoui-Montassar.

@GromNaN GromNaN merged commit 615378c into symfony:6.4 Aug 7, 2025
16 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing translations for Arabic (ar)
3 participants