[HttpKernel] Adjust priority of CacheAttributeListener to ensure Vary header is not skipped
#61368
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
…ry header is not skipped
9eec426 to
04f4315
Compare
|
If we want to avoid changing the priority, we can add a condition to check whether the request has the _vary_by_language attribute set to true, and the response's Vary header contains only Accept-Language. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the priority of the
KernelEvents::RESPONSEevent from -10 to 10 in theCacheAttributeListener.Reason
Previously, the
CacheAttributeListenerwas executed after theResponseListener. When theset_locale_from_accept_languageoption is enabled inframework.yaml, theResponseListenersets a Vary header on the response. BecauseCacheAttributeListenerchecks if a Vary header already exists before modifying it, its logic was being bypassed if it ran after theResponseListener.Fix
By increasing the event priority, we ensure the
CacheAttributeListenerruns before theResponseListener, allowing it to correctly evaluate and modify the Vary header when necessary.References
Note
I'm not sure if changing the priority of this event in this listener could have other side effects.