tinyhttp · aarontravass · Oct 8, 2023 · Oct 8, 2023 · Oct 10, 2023 · Oct 23, 2023
diff --git a/biome.json b/biome.json
@@ -25,7 +25,9 @@
     "rules": {
       "recommended": true,
       "correctness": {
-        "noVoidTypeReturn": "off"
+        "noVoidTypeReturn": "off",
+        "noUnusedImports": "error",
+        "noUnusedVariables": "error"
       },
       "style": {
         "noParameterAssign": "off"

diff --git a/examples/custom-view/index.js b/examples/custom-view/index.js
@@ -17,7 +17,7 @@ app.engine('html', async (path, locals, _opts, cb) => {
   cb(null, renderedTemplate)
 })
 
-app.get('/', (req, res) => {
+app.get('/', (_req, res) => {
   res.render('hello.html', { name: 'v1rtl' })
 })
 

diff --git a/examples/postgresql-typeorm/src/index.ts b/examples/postgresql-typeorm/src/index.ts
@@ -46,7 +46,7 @@ createConnection()
 
     // register routes
 
-    app.get('/users', async (req: Request, res: Response, next) => {
+    app.get('/users', async (_req: Request, res: Response, next) => {
       try {
         const users = await userRepository.find()
         res.json(users)

diff --git a/examples/preact-ssr/index.js b/examples/preact-ssr/index.js
@@ -10,7 +10,7 @@ const app = new App()
 const PreactApp = ({ page }) => (page ? html`<h1>You visited ${page}</h1>` : html`<h1>Hello World</h1>`)
 
 app
-  .get('/htm.js', async (req, res) => {
+  .get('/htm.js', async (_req, res) => {
     const preactFile = await readFile(`${process.cwd()}/node_modules/htm/preact/standalone.module.js`)
 
     res.set('Content-Type', 'text/javascript').send(preactFile.toString())

diff --git a/examples/swagger/index.js b/examples/swagger/index.js
@@ -12,7 +12,7 @@ const schema = {
 const app = new App()
 
 app
-  .get('/docs/:docId', addToDocs({ params: { docId: 'number' } }), (req, res) => {
+  .get('/docs/:docId', addToDocs({ params: { docId: 'number' } }), (_req, res) => {
     res.status(200).send('done')
   })
   .post(
@@ -27,10 +27,10 @@ app
     ),
     (_req, res) => void res.status(200).send('done')
   )
-  .get('/users', addToDocs({ query: { userId: { type: 'number', optional: true } } }, ['users']), (req, res) => {
+  .get('/users', addToDocs({ query: { userId: { type: 'number', optional: true } } }, ['users']), (_req, res) => {
     res.status(200).send('done')
   })
-  .get('/:userId/:docId', addToDocs({ params: { userId: 'number', docId: 'number' } }), (req, res) => {
+  .get('/:userId/:docId', addToDocs({ params: { userId: 'number', docId: 'number' } }), (_req, res) => {
     res.status(200).send('done')
   })
 

diff --git a/examples/turbo-http/index.js b/examples/turbo-http/index.js
@@ -3,7 +3,7 @@ import { status } from '@tinyhttp/send'
 import turbo from 'turbo-http'
 
 const app = new App({
-  applyExtensions: (_req, res, next) => {
+  applyExtensions: (_req, _res, next) => {
     next()
   },
   onError: (err, req, res) => {

diff --git a/examples/vue-ssr/index.js b/examples/vue-ssr/index.js
@@ -7,7 +7,7 @@ const app = new App()
 
 app
   .use(sirv())
-  .get('*', async (req, res) => {
+  .get('*', async (_req, res) => {
     const app = createApp()
 
     const html = await renderToString(app)

diff --git a/package.json b/package.json
@@ -43,7 +43,9 @@
     "test:coverage": "vitest run --dir tests --coverage",
     "test": "pnpm test:coverage",
     "lint": "biome lint .",
+    "lint:fix": "biome lint --fix .",
     "format": "biome format .",
+    "format:fix": "biome format --fix .",
     "check": "biome check .",
     "echo:ancestor": "echo ${ANCESTOR_REF:-$(git merge-base origin/master HEAD)}",
     "build": "pnpm -r build",

diff --git a/packages/accepts/src/index.ts b/packages/accepts/src/index.ts
@@ -18,7 +18,7 @@ export class Accepts {
    *
    * The `type` value may be a single mime type string such as "application/json", the extension name such as "json" or an array `["json", "html", "text/plain"]`. When a list or array is given the _best_ match, if any is returned. When no types are given as arguments, returns all types accepted by the client in the preference order.
    */
-  types(types: string | string[], ...args: string[]): string[] | string | false {
+  types(types?: string | string[], ...args: string[]): string[] | string | false {
     let mimeTypes: string[] = []
 
     // support flattened arguments
@@ -108,7 +108,7 @@ export class Accepts {
    *     ['es', 'pt', 'en']
    *
    */
-  languages(languages: string | string[], ...args: string[]): string | string[] | boolean {
+  languages(languages?: string | string[], ...args: string[]): string | string[] | boolean {
     let _languages: string[] = languages as string[]
 
     // support flattened arguments

diff --git a/packages/app/src/app.ts b/packages/app/src/app.ts
@@ -314,9 +314,9 @@ export class App<Req extends Request = Request, Res extends Response = Response>
 
     const exts = this.applyExtensions || extendMiddleware<RenderOptions>(this)
 
-    req.originalUrl = req.url || req.originalUrl
+    req.originalUrl = req.originalUrl || req.url
 
-    const pathname = getPathname(req.originalUrl)
+    const pathname = getPathname(req.url)
 
     const matched = this.#find(pathname)
 
@@ -359,9 +359,8 @@ export class App<Req extends Request = Request, Res extends Response = Response>
       try {
         params = regex ? getURLParams(regex, pathname) : {}
       } catch (e) {
-        console.error(e)
-        if (e instanceof URIError) return res.sendStatus(400)
-        throw e
+        if (e instanceof URIError) return res.sendStatus(400) // Handle malformed URI
+        return this.onError(e, req, res)
       }
 
       // Warning: users should not use :wild as a pattern
@@ -379,7 +378,7 @@ export class App<Req extends Request = Request, Res extends Response = Response>
       req.params = { ...req.params, ...params }
 
       if (mw.type === 'mw') {
-        req.url = lead(req.originalUrl.substring(prefix.length))
+        req.url = lead(req.url.substring(prefix.length))
       }
 
       if (!req.path) req.path = getPathname(req.url)

diff --git a/packages/app/src/request.ts b/packages/app/src/request.ts
@@ -25,7 +25,7 @@ export const getProtocol = (req: Request, trust: Trust): Protocol => {
 
   if (!trustRemoteAddress(req, trust)) return proto
 
-  const header = (req.headers['X-Forwarded-Proto'] as string) || proto
+  const header = (req.get('X-Forwarded-Proto') as string) || proto
 
   const index = header.indexOf(',')
 

diff --git a/packages/app/src/view.ts b/packages/app/src/view.ts
@@ -14,7 +14,7 @@ import type { TemplateEngine, TemplateEngineOptions } from './types.js'
 function tryStat(path: string) {
   try {
     return statSync(path)
-  } catch (e) {
+  } catch (_e) {
     return undefined
   }
 }

diff --git a/packages/cookie/src/index.ts b/packages/cookie/src/index.ts
@@ -14,7 +14,7 @@ const fieldContentRegExp = /^[\u0009\u0020-\u007e\u0080-\u00ff]+$/
 function tryDecode(str: string, decode: (str: string) => string) {
   try {
     return decode(str)
-  } catch (e) {
+  } catch (_e) {
     return str
   }
 }

diff --git a/packages/proxy-addr/src/index.ts b/packages/proxy-addr/src/index.ts
@@ -164,7 +164,7 @@ function parseNetmask(netmask: string) {
  * @param trust
  * @public
  */
-export function proxyaddr(req: Req, trust: Trust): string {
+function proxyaddr(req: Req, trust: Trust): string {
   const addrs = alladdrs(req, trust)
 
   return addrs[addrs.length - 1]
@@ -216,5 +216,4 @@ function trustSingle(subnet: Subnet) {
   }
 }
 
-export { alladdrs as all }
-export { compile }
+export { compile, alladdrs as all, proxyaddr }
diff --git a/packages/req/src/fresh.ts b/packages/req/src/fresh.ts
@@ -34,7 +34,6 @@ function isStale(etag: string, noneMatch: string) {
 export function fresh(reqHeaders: IncomingHttpHeaders, resHeaders: OutgoingHttpHeaders) {
   const modifiedSince = reqHeaders['if-modified-since']
   const noneMatch = reqHeaders['if-none-match']
-
   if (!modifiedSince && !noneMatch) return false
 
   const cacheControl = reqHeaders['cache-control']

diff --git a/packages/type-is/src/index.ts b/packages/type-is/src/index.ts
@@ -14,7 +14,7 @@ function tryNormalizeType(value: string) {
 
   try {
     return normalizeType(value)
-  } catch (err) {
+  } catch (_err) {
     return null
   }
 }