tinyhttp · ItayLeon-Max · Apr 28, 2025 · Apr 29, 2025 · Apr 29, 2025 · Apr 29, 2025
diff --git a/packages/content-disposition/src/index.ts b/packages/content-disposition/src/index.ts
@@ -82,6 +82,8 @@ function format({
 function createParams(filename?: string, fallback?: string | boolean) {
   if (filename === undefined) return {}
 
+  if (filename === '') return { filename }
+
   const params: Partial<
     Record<string, string> & {
       filename: string
@@ -138,6 +140,7 @@ export function contentDisposition(
 }
 
 function decodefield(str: string) {
+  if (str === '') return '' // empty string
   const match = EXT_VALUE_REGEXP.exec(str)
   if (!match) throw new TypeError('invalid extended field value')
 
@@ -198,11 +201,15 @@ export function parse(header: string): ContentDisposition {
     names.push(key)
 
     if (key.indexOf('*') + 1 === key.length) {
-      // decode extended value
       key = key.slice(0, -1)
+
+      if (!value) {
+        params[key] = ''
+        continue
+      }
+
       value = decodefield(value)
 
-      // overwrite existing value
       params[key] = value
       continue
     }

diff --git a/packages/req/package.json b/packages/req/package.json
@@ -22,6 +22,7 @@
   },
   "dependencies": {
     "@tinyhttp/accepts": "workspace:*",
+    "@tinyhttp/req": "workspace:^",
     "@tinyhttp/type-is": "workspace:*",
     "@tinyhttp/url": "workspace:*",
     "header-range-parser": "^1.1.3"

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/tests/modules/content-disposition.test.ts b/tests/modules/content-disposition.test.ts
@@ -611,3 +611,9 @@ describe('parse(string)', () => {
     })
   })
 })
+
+it('should work when file name is empty', () => {
+  const encoded = contentDisposition('', { type: 'inline' })
+  const parsed = parse(encoded)
+  expect(parsed.parameters.filename).toBe('')
+})