Skip to content

fix(eslint-plugin): [no-floating-promises] allowForKnownSafeCalls now supports function names (fixes #11423) #11430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+41 −2
Open

fix(eslint-plugin): [no-floating-promises] allowForKnownSafeCalls now supports function names (fixes #11423) #11430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4d5dae
Chore: add test cases for no-floating-promises allowForKnownSafeCalls…
976520 Jul 28, 2025
8c1cc90
Fix: no-floating-promises allowForKnownSafeCalls not working for func…
976520 Jul 28, 2025
af92aea
Chore: update docs and snapshots for no-floating-promises fix
976520 Jul 28, 2025
77bcc24
Merge branch 'main' into main
976520 Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/eslint-plugin/docs/rules/no-floating-promises.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ unsafe('...', () => {});
</TabItem>
<TabItem value="✅ Correct">

```ts option='{"allowForKnownSafeCalls":[{"from":"file","name":"safe","path":"input.ts"}]}' skipValidation
```ts option='{"allowForKnownSafeCalls":[{"from":"file","name":"safe","path":"input.ts"}]}'
declare function safe(...args: unknown[]): Promise<void>;

safe('...', () => {});
Expand Down
12 changes: 12 additions & 0 deletions packages/eslint-plugin/src/rules/no-floating-promises.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
readonlynessOptionsSchema,
skipChainExpression,
typeMatchesSomeSpecifier,
valueMatchesSomeSpecifier,
} from '../util';
import {
parseCatchCall,
Expand Down Expand Up @@ -242,6 +243,17 @@ export default createRule<Options, MessageId>({

const type = services.getTypeAtLocation(node.callee);

if (
valueMatchesSomeSpecifier(
node.callee,
allowForKnownSafeCalls,
services.program,
type,
)
) {
return true;
}

return typeMatchesSomeSpecifier(
type,
allowForKnownSafeCalls,
Expand Down
1 change: 0 additions & 1 deletion packages/eslint-plugin/tests/docs-eslint-output-snapshots/no-floating-promises.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions packages/eslint-plugin/tests/rules/no-floating-promises.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,6 +866,34 @@ declare function createMyThenable(): MyThenable;

createMyThenable();
`,
{
code: `
const randomAsyncFunction = async () => {
return Promise.resolve(true);
};

randomAsyncFunction();
`,
options: [
{
allowForKnownSafeCalls: ['randomAsyncFunction'],
},
],
},
{
code: `
async function myAsyncFunction() {
return Promise.resolve('test');
}

myAsyncFunction();
`,
options: [
{
allowForKnownSafeCalls: ['myAsyncFunction'],
},
],
},
],

invalid: [
Expand Down
Loading