Skip to content

fix: tsconfigRootDir bugs #11463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix: tsconfigRootDir bugs #11463

wants to merge 5 commits into from
+119 −33

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Aug 6, 2025 •
edited
Loading

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Aug 6, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 04366b0
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6893dff4366d620008515cde
😎 Deploy Preview https://deploy-preview-11463--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🟢 up 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 6, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 04366b0

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 18s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 21s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
Additional runs (24) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-08-06 23:12:04 UTC

@codecov Codecov
Copy link

codecov bot commented Aug 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 86.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.87%. Comparing base (88b063e) to head (c641467).

⚠️ Current head c641467 differs from pull request most recent head 04366b0

Please upload reports for the commit 04366b0 to get more accurate results.

Files with missing lines Patch % Lines
...pt-estree/src/parseSettings/createParseSettings.ts 70.83% 7 Missing ⚠️

❌ Your patch check has failed because the patch coverage (86.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11463      +/-   ##
==========================================
- Coverage   90.88%   90.87%   -0.01%     
==========================================
  Files         505      505              
  Lines       51121    51164      +43     
  Branches     8413     8419       +6     
==========================================
+ Hits        46459    46497      +38     
- Misses       4648     4653       +5     
  Partials       14       14
Flag Coverage Δ
unittest 90.87% <86.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ges/typescript-estree/src/create-program/shared.ts 88.75% <100.00%> (+0.94%) ⬆️
...-estree/src/parseSettings/getProjectConfigFiles.ts 100.00% <100.00%> (ø)
...pt-estree/src/parseSettings/createParseSettings.ts 90.09% <70.83%> (-2.10%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblinger kirkwaiblinger mentioned this pull request Aug 6, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kirkwaiblinger