Skip to content

fix(scope-manager): exclude Program from DefinitionBase node types #11469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dbarabashh
Copy link
Contributor

@dbarabashh dbarabashh commented Aug 8, 2025

Fix #11334

PR Checklist

Overview

This PR improves type safety in the scope-manager package by preventing TSESTree.Program nodes from being used as definition nodes.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @dbarabashh!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Aug 8, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5dd757a
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6897cff66f6a9c0008a4d4fc
😎 Deploy Preview https://deploy-preview-11469--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Aug 8, 2025

View your CI Pipeline Execution ↗ for commit 5dd757a

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 5s View ↗
nx run-many -t lint ✅ Succeeded 3m 20s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 16s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx run types:build ✅ Succeeded 6s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 7s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-08-09 22:58:22 UTC

@dbarabashh
Copy link
Contributor Author

I am not sure that the linter failed now exactly because of my changes, because locally this command was successful

@JoshuaKGoldberg
Copy link
Member

Try a yarn build first, then a yarn lint? It looks like the types are better informed because of this change (nice!), so lint rules are pointing out previously missed unnecessary ?.s and the like.

Copy link

codecov bot commented Aug 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.87%. Comparing base (7319bad) to head (5dd757a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11469      +/-   ##
==========================================
- Coverage   90.88%   90.87%   -0.01%     
==========================================
  Files         505      505              
  Lines       51125    51117       -8     
  Branches     8415     8415              
==========================================
- Hits        46463    46455       -8     
  Misses       4648     4648              
  Partials       14       14              
Flag Coverage Δ
unittest 90.87% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/eslint-plugin/src/util/collectUnusedVariables.ts 96.19% <100.00%> (ø)
...ges/scope-manager/src/definition/DefinitionBase.ts 100.00% <ø> (ø)
...src/definition/ImplicitGlobalVariableDefinition.ts 100.00% <ø> (ø)
packages/scope-manager/src/referencer/Reference.ts 93.44% <ø> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dbarabashh
Copy link
Contributor Author

@JoshuaKGoldberg thank you, done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: DefinitionBase shouldn't allow its Node type to be TSESTree.Program
2 participants