Linux only: full system-wide install with uSockets + Hints for CMake users #1702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@uNetworkingAB any thoughts on this? |
|
bump |
pixel-prady
approved these changes
Aug 10, 2025
vitaly-castLabs
approved these changes
Aug 11, 2025
|
Can someone with write access please approve this? It doesn't let me merge otherwise. Picking an arbitrary author @gubaojian would you be able to help with this? |
|
The uSockets install lines could be added as an install target in uSockets itself. uWebSockets is a separate project that already installs itself. If anything, uSockets could get its own "make install". The "how to clone a repo" and "CMake snippets" texts are irrelevant to this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1600
make installcommand.