Skip to content

bug fix for #4515 #4521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bug fix for #4515 #4521

wants to merge 1 commit into from

Conversation

guy-maurel
Copy link
Contributor

Thanks to @c2main who solve the bug #4515

@c2main
Copy link
Contributor

c2main commented May 29, 2025

I have spotted some 6 other places with similar risk, and 1 where it's one "on purpose" to get the max value as a result.

Maybe it's best to merge this one, and revisit with a more global approach...

@micheleCTDEAdmin
Copy link
Collaborator

Based on comment on issue #4515, we should try to fix the abnormal value of GetColumn() rather than merging a fix that we already suspect is not right in first place, based on comments from @c2main in #4515.

micheleCTDEAdmin
micheleCTDEAdmin requested changes May 30, 2025
View reviewed changes
Copy link
Collaborator

@micheleCTDEAdmin micheleCTDEAdmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We get the value 18446744073709551612 for the bar column, which is -4 when converted to size_t.
This PR is definitely not correct. We should instead find out why we get the wrong column and fix that instead.

@c2main
Copy link
Contributor

c2main commented May 30, 2025

We get the value 18446744073709551612 for the bar column, which is -4 when converted to size_t. This PR is definitely not correct. We should instead find out why we get the wrong column and fix that instead.

FYI I have enough for my case to fix all, though there is something pending. I think that some code path is/are missing a SetNlCount(), thus col_delta is not reset to 0, leading to unexpected delta greatest than position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micheleCTDEAdmin micheleCTDEAdmin micheleCTDEAdmin requested changes

@gmaurel gmaurel Awaiting requested review from gmaurel gmaurel is a code owner

@mwoehlke-kitware mwoehlke-kitware Awaiting requested review from mwoehlke-kitware mwoehlke-kitware is a code owner

@PoeticPeteAdmin PoeticPeteAdmin Awaiting requested review from PoeticPeteAdmin PoeticPeteAdmin is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guy-maurel @c2main @micheleCTDEAdmin @gmaurel