feat(Checkbox): add max prop #2058
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
… auto-focus when opened (unovue#2055) * fix(DatePicker): allow `initialFocus` to control the calendar's auto-focus on open * fix: corrects imports * refactor: remove `initialFocus`
|
Hi @malik-jouda . Thanks for the PR. But could put in more description of what this PR is trying to implement? |
|
While functionally sound, I have concerns wrt accessibility and user experience. It is very reasonable to come to the conclusion the checkboxes are "broken" if there is no feedback to the user that they have reached the limit (both visually, and via tools like screen readers). It may be a good use-case for using |
This comment was marked as resolved.
This comment was marked as resolved.
…lendar's auto-focus when opened (unovue#2055)" This reverts commit c764bf5.
This reverts commit e0ec317.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.