Use select event instead f click in DropdownMenuItem demo
#2105
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If anyone does come across the same issue I had, it was consistently "caused", essentially by changing an async function somewhere in the async () => {
// Do some stuff
return true;
}to async () => {
// Do the same stuff as above
return await Promise.resolve(true);
}Just by plugging that into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the example / demo is most often the place developers look first, it would make sense to use the exposed
selectevent here, instead of a genericclickevent.Originally I had planned to open an issue, because when using the click event, I had some strange behavior when selecting an item: Despite the menu closing, the
pointer-events: nonestyle was still applied to thebodyelement. Despite my best efforts, I was not able to create a minimal (not) working example. My best guess is some weird timing issues in the async functions I used. If I do manage to reproduce the behaviour, I will create an issue.Short story is, when I used
selectinstead ofclick, thepointer-events: none;was removed correctly, so maybe this will prevent others from running into the same issue. And, I do think regardless of a possible issue, documenting theselectevent does make more sense than the current@click.