fix(@vben/backend-mock): fix all ts type errors in this module #6613
Conversation
|
WalkthroughAdded explicit h3 imports across many handlers, wrapped successful/error responses with response helpers, tightened JWT/header parsing and mock-user lookups, improved table sorting/pagination, replaced tsconfig extend with a detailed config, and introduced an unimplemented local Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant API
participant JWTUtils
participant MockData
participant ResponseHelpers
Client->>API: Request (Authorization header / cookies / query)
API->>JWTUtils: verifyAccessToken / verifyRefreshToken
JWTUtils->>MockData: find user by username
MockData-->>JWTUtils: user or null
JWTUtils-->>API: payload or null
API->>ResponseHelpers: format success or error
ResponseHelpers-->>Client: HTTP response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 3
🔭 Outside diff range comments (2)
apps/backend-mock/api/system/dept/.post.ts (1)
8-18: Critical: Remove the broken localeventHandlerfunction and add the missing import.The local
eventHandlerfunction at lines 16-18 shadows the propereventHandlerfrom 'h3' and will cause runtime errors. This breaks the entire endpoint.Apply this fix to align with other API endpoints:
+import { eventHandler } from 'h3'; import { verifyAccessToken } from '~/utils/jwt-utils'; import { sleep, unAuthorizedResponse, useResponseSuccess, } from '~/utils/response'; export default eventHandler(async (event) => { const userinfo = verifyAccessToken(event); if (!userinfo) { return unAuthorizedResponse(event); } await sleep(600); return useResponseSuccess(null); }); -function eventHandler(_: (event: any) => Promise<any>) { - throw new Error('Function not implemented.'); -}apps/backend-mock/api/auth/refresh.post.ts (1)
24-29: Handle potential undefined user lookup.Similar to the issue in
jwt-utils.ts, the user lookup could returnundefined, but the code assumes it will always find a user. Consider adding explicit handling:const findUser = MOCK_USERS.find( (item) => item.username === userinfo.username, ); if (!findUser) { return forbiddenResponse(event); }The current code already has this check, so this is actually correct. My apologies for the confusion.
🧹 Nitpick comments (4)
apps/backend-mock/utils/cookie-utils.ts (1)
3-4: Consider extracting the cookie name and adding an explicit path for cleaner, more reliable operationsRepeated string literals (
'jwt') make future changes error-prone, and an explicitpath: '/'guarantees the delete operation targets the same cookie that was set.+const REFRESH_TOKEN_COOKIE = 'jwt'; export function clearRefreshTokenCookie(event: H3Event<EventHandlerRequest>) { - deleteCookie(event, 'jwt', { + deleteCookie(event, REFRESH_TOKEN_COOKIE, { httpOnly: true, sameSite: 'none', secure: true, + path: '/', // ensure consistent scope }); } export function setRefreshTokenCookie( event: H3Event<EventHandlerRequest>, refreshToken: string, ) { - setCookie(event, 'jwt', refreshToken, { + setCookie(event, REFRESH_TOKEN_COOKIE, refreshToken, { httpOnly: true, maxAge: 24 * 60 * 60, // unit: seconds sameSite: 'none', secure: true, + path: '/', // mirror deletion path }); } export function getRefreshTokenFromCookie(event: H3Event<EventHandlerRequest>) { - const refreshToken = getCookie(event, 'jwt'); + const refreshToken = getCookie(event, REFRESH_TOKEN_COOKIE); return refreshToken; }apps/backend-mock/api/system/menu/path-exists.ts (1)
1-5: Minor typing tidy-up opportunityThe new imports are correct; while touching this area, you could tighten
pathMap’s value type tostring(currentlyany) for stronger compile-time safety.-const pathMap: Record<string, any> = { '/': 0 }; +const pathMap: Record<string, string> = { '/': '0' };This removes an
any, aligns with the string coercions below, and maintains behaviour.apps/backend-mock/utils/jwt-utils.ts (1)
39-42: Consider safer JWT verification approach.The double type assertion
as unknown as UserPayloadbypasses TypeScript's type safety. While this is common for JWT handling, consider adding runtime validation for critical properties.- const decoded = jwt.verify( - token, - ACCESS_TOKEN_SECRET, - ) as unknown as UserPayload; + const decoded = jwt.verify(token, ACCESS_TOKEN_SECRET) as unknown; + if (typeof decoded !== 'object' || decoded === null || !('username' in decoded)) { + return null; + } + const payload = decoded as UserPayload;apps/backend-mock/api/auth/refresh.post.ts (1)
34-34: Consider consistent response wrapping.This endpoint returns a bare
accessTokenwhile other endpoints use response wrappers likeuseResponseSuccess. Consider maintaining consistency:- return accessToken; + return useResponseSuccess({ accessToken });However, verify this doesn't break existing API consumers before making this change.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (26)
apps/backend-mock/api/auth/codes.ts(1 hunks)apps/backend-mock/api/auth/login.post.ts(1 hunks)apps/backend-mock/api/auth/logout.post.ts(1 hunks)apps/backend-mock/api/auth/refresh.post.ts(1 hunks)apps/backend-mock/api/demo/bigint.ts(1 hunks)apps/backend-mock/api/menu/all.ts(1 hunks)apps/backend-mock/api/status.ts(1 hunks)apps/backend-mock/api/system/dept/.post.ts(1 hunks)apps/backend-mock/api/system/dept/[id].delete.ts(1 hunks)apps/backend-mock/api/system/dept/[id].put.ts(1 hunks)apps/backend-mock/api/system/dept/list.ts(1 hunks)apps/backend-mock/api/system/menu/list.ts(1 hunks)apps/backend-mock/api/system/menu/name-exists.ts(1 hunks)apps/backend-mock/api/system/menu/path-exists.ts(1 hunks)apps/backend-mock/api/system/role/list.ts(1 hunks)apps/backend-mock/api/table/list.ts(2 hunks)apps/backend-mock/api/test.get.ts(1 hunks)apps/backend-mock/api/test.post.ts(1 hunks)apps/backend-mock/api/upload.ts(1 hunks)apps/backend-mock/api/user/info.ts(1 hunks)apps/backend-mock/middleware/1.api.ts(1 hunks)apps/backend-mock/routes/[...].ts(1 hunks)apps/backend-mock/tsconfig.json(1 hunks)apps/backend-mock/utils/cookie-utils.ts(1 hunks)apps/backend-mock/utils/jwt-utils.ts(3 hunks)apps/backend-mock/utils/response.ts(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: the `/api/user/info` endpoint in the vue vben admin project is protected by middleware that handles ...
Learnt from: wll8
PR: vbenjs/vue-vben-admin#4018
File: apps/backend-mock/api/user.cjs:10-24
Timestamp: 2024-08-03T03:11:46.130Z
Learning: The `/api/user/info` endpoint in the Vue Vben Admin project is protected by middleware that handles user authentication and returns an error if the user is not found or authentication fails.
Applied to files:
apps/backend-mock/api/user/info.tsapps/backend-mock/api/demo/bigint.ts
📚 Learning: in `docs/src/components/common-ui/vben-vxe-table.md`, the code examples are provided within markdown...
Learnt from: ArthurDarkstone
PR: vbenjs/vue-vben-admin#4807
File: docs/src/components/common-ui/vben-vxe-table.md:65-84
Timestamp: 2024-11-05T10:34:13.846Z
Learning: In `docs/src/components/common-ui/vben-vxe-table.md`, the code examples are provided within markdown scripts for documentation and do not require import statements or explicit type annotations.
Applied to files:
apps/backend-mock/api/table/list.ts
🧬 Code Graph Analysis (1)
apps/backend-mock/utils/jwt-utils.ts (1)
apps/backend-mock/utils/mock-data.ts (2)
MOCK_USERS(10-34)UserInfo(1-8)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: post-update (ubuntu-latest)
- GitHub Check: post-update (windows-latest)
🔇 Additional comments (24)
apps/backend-mock/api/system/dept/[id].delete.ts (1)
1-1: Import addition looks goodExplicitly importing
eventHandlerresolves the TS type error and clarifies the dependency. No further issues spotted.apps/backend-mock/api/system/dept/[id].put.ts (1)
1-1: Import addition looks goodSame rationale as the DELETE handler—dependency is now explicit and type-safe.
apps/backend-mock/middleware/1.api.ts (1)
1-1: Import addition looks good
defineEventHandleris now explicitly sourced fromh3, eliminating the previous implicit global and fixing the type error.apps/backend-mock/api/test.get.ts (1)
1-1: LGTM! Explicit import resolves TypeScript type error.The explicit import of
defineEventHandlerfrom 'h3' ensures proper TypeScript type resolution and aligns with the PR objective to fix all TypeScript type errors.apps/backend-mock/api/test.post.ts (1)
1-1: LGTM! Explicit import resolves TypeScript type error.The explicit import of
defineEventHandlerfrom 'h3' ensures proper TypeScript type resolution, matching the pattern used across other API handlers in this PR.apps/backend-mock/api/system/dept/list.ts (1)
2-2: LGTM! Explicit import resolves TypeScript type error.The explicit import of
eventHandlerfrom 'h3' properly addresses the TypeScript type resolution issue. The usage ofeventHandler(vsdefineEventHandler) is appropriate for this async handler implementation.apps/backend-mock/utils/response.ts (1)
3-3: LGTM! Explicit import enables proper HTTP status handling.The explicit import of
setResponseStatusfrom 'h3' resolves TypeScript type errors and enables theforbiddenResponseandunAuthorizedResponsefunctions to properly set HTTP status codes 403 and 401 respectively.apps/backend-mock/api/system/menu/list.ts (1)
1-1: LGTM! Explicit import resolves TypeScript type error.The explicit import of
eventHandlerfrom 'h3' ensures proper TypeScript type resolution and follows the consistent pattern established across other system API handlers in this PR.apps/backend-mock/routes/[...].ts (1)
1-1: Good TypeScript improvement!Adding the explicit import for
defineEventHandlerresolves potential TypeScript module resolution issues and improves code clarity. This aligns perfectly with the PR objective to fix all TS type errors.apps/backend-mock/api/system/role/list.ts (1)
2-2: Excellent TypeScript type safety improvement!Adding explicit imports for
eventHandlerandgetQueryfrom 'h3' resolves TypeScript module resolution issues. These functions are actively used in the handler (lines 42 and 57), so the explicit imports are essential for proper type checking.apps/backend-mock/api/auth/login.post.ts (1)
1-12: Comprehensive TypeScript and response handling improvements!The added imports are all actively used throughout the handler:
setResponseStatus(line 17) for proper HTTP status codesMOCK_USERS(line 24) for user authentication- Response utilities (lines 18, 30, 38) for consistent API responses
This standardizes response handling and resolves TypeScript type errors effectively.
apps/backend-mock/api/status.ts (1)
1-2: TypeScript imports properly added!All imported functions are actively used in the handler. The explicit imports resolve TypeScript module resolution issues and maintain consistency with other API endpoints.
apps/backend-mock/api/user/info.ts (3)
1-1: Good TypeScript improvement!Adding the explicit
eventHandlerimport resolves TypeScript module resolution issues and follows the consistent pattern across all API endpoints.
3-3: Response standardization improvement!Adding
useResponseSuccessto the import and using it on line 10 standardizes the response format with other API endpoints while maintaining the same user info data structure.
10-10: Consistent response wrapper applied!The change from returning raw
userinfotouseResponseSuccess(userinfo)standardizes the response format across the API while preserving the authentication logic and user data structure.apps/backend-mock/api/demo/bigint.ts (1)
1-3: LGTM! Import standardization improves type safety.The explicit imports from 'h3' and the response utilities align with the PR's objective to fix TypeScript type errors and maintain consistency across the backend-mock module.
apps/backend-mock/api/upload.ts (1)
1-3: LGTM! Consistent with API-wide standardization.The explicit import of
eventHandlerand the addition ofuseResponseSuccessalign with the standardization pattern across the backend-mock API endpoints.apps/backend-mock/api/auth/codes.ts (1)
1-4: LGTM! Proper standardization of imports and response handling.The explicit import of
eventHandlerfrom 'h3' and the use ofuseResponseSuccessmaintain consistency with the API-wide standardization effort.apps/backend-mock/api/system/menu/name-exists.ts (1)
1-4: LGTM! Consistent with the standardization pattern.The explicit imports from 'h3' (
eventHandler,getQuery) and the addition ofuseResponseSuccessalign with the TypeScript type safety improvements across the backend-mock module.apps/backend-mock/api/menu/all.ts (1)
1-4: LGTM! Explicit imports improve type safety.The addition of explicit imports for
eventHandler,MOCK_MENUS, anduseResponseSuccessenhances TypeScript type checking and makes dependencies clear. This aligns well with the PR's objective to fix TypeScript type errors.apps/backend-mock/api/auth/logout.post.ts (1)
1-1: LGTM! Standardized imports and response handling.The explicit imports for
defineEventHandleranduseResponseSuccessimprove type safety and maintain consistency with other API endpoints in the backend-mock module.Also applies to: 6-6
apps/backend-mock/api/auth/refresh.post.ts (1)
1-1: LGTM! Explicit imports improve type safety.The addition of explicit imports for
defineEventHandler, JWT utilities, andMOCK_USERSenhances type checking and makes dependencies clear.Also applies to: 7-8
apps/backend-mock/tsconfig.json (1)
2-13: LGTM! Comprehensive TypeScript configuration improvements.The configuration changes are well-structured and support the codebase modernization:
- JSON schema reference improves IDE support
- Shared base config promotes consistency across the project
- Composite builds enhance performance in monorepo setups
- Path alias
~/utils/*properly supports the import patterns used throughout the codebase- Setting
noEmit: falseallows proper build output generationThese changes effectively support the TypeScript error fixes implemented across the backend-mock module.
apps/backend-mock/api/table/list.ts (1)
2-8: LGTM! Import standardization improves type safety.The explicit imports of
eventHandlerandgetQueryfrom 'h3' and addingsleepto the response utilities import enhance type safety and align with the standardization pattern across the backend-mock API routes.
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
apps/backend-mock/api/table/list.ts (1)
85-85: It looks like pagination params come in as strings (or even arrays) and are passed directly into the helper, which accepts number|string but will not normalize bad values. We should parse and default them before calling usePageResponseSuccess.Suggested fix in apps/backend-mock/api/table/list.ts (lines 83–85):
- const { page, pageSize } = getQuery(event) - return usePageResponseSuccess(page as string, pageSize as string, listData) + const { page: rawPage, pageSize: rawPageSize } = getQuery(event) + const pageNum = parseInt(Array.isArray(rawPage) ? rawPage[0] : rawPage ?? '', 10) + const pageSizeNum = parseInt( + Array.isArray(rawPageSize) ? rawPageSize[0] : rawPageSize ?? '', + 10 + ) + return usePageResponseSuccess( + Number.isFinite(pageNum) && pageNum > 0 ? pageNum : 1, + Number.isFinite(pageSizeNum) && pageSizeNum > 0 ? pageSizeNum : 10, + listData + )
- We normalize arrays by taking the first element.
- We fallback page to 1 and pageSize to 10 when parsing fails.
- This ensures we never pass
"undefined"or"1,2"to the helper.
♻️ Duplicate comments (1)
apps/backend-mock/api/table/list.ts (1)
66-71: Fix inconsistent sorting (price asc bug, numeric/boolean/date handling, desc branch)
- Ascending sorts price lexicographically (string), but descending parses numerically. This yields wrong results (e.g., "100" < "20").
- Descending branch compares non-price fields as strings, breaking for numeric fields (quantity, rating, weight).
- Dates and booleans degrade to string comparison.
Unify comparator: detect numbers/numeric-like, Date, boolean; fallback to string with numeric-aware localeCompare. Invert by isDesc.
Apply this diff to the sort comparator:
- listData.sort((a, b) => { - if (sortOrder === 'asc') { - const aValue = a[sortKey]; - const bValue = b[sortKey]; - - return typeof aValue === 'number' && typeof bValue === 'number' - ? aValue - bValue - : String(aValue).localeCompare(String(bValue)); - } else { - if (sortKey === 'price') { - return ( - Number.parseFloat(b[sortKey] as string) - - Number.parseFloat(a[sortKey] as string) - ); - } else { - return (a[sortKey] as string) < (b[sortKey] as string) ? 1 : -1; - } - } - }); + listData.sort((a, b) => { + const aValue = a[sortKey] as unknown; + const bValue = b[sortKey] as unknown; + + // Date + if (aValue instanceof Date && bValue instanceof Date) { + const diff = aValue.getTime() - bValue.getTime(); + return isDesc ? -diff : diff; + } + + // Boolean + if (typeof aValue === 'boolean' && typeof bValue === 'boolean') { + const diff = Number(aValue) - Number(bValue); + return isDesc ? -diff : diff; + } + + // Number or numeric-like strings (e.g., price) + const aNum = + typeof aValue === 'number' ? aValue : Number.parseFloat(String(aValue)); + const bNum = + typeof bValue === 'number' ? bValue : Number.parseFloat(String(bValue)); + const bothNumeric = !Number.isNaN(aNum) && !Number.isNaN(bNum); + + if (bothNumeric) { + const diff = aNum - bNum; + return isDesc ? -diff : diff; + } + + // Fallback string compare (numeric-aware) + const diff = String(aValue).localeCompare(String(bValue), undefined, { + numeric: true, + sensitivity: 'base', + }); + return isDesc ? -diff : diff; + });Also applies to: 73-80
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/backend-mock/api/table/list.ts(2 hunks)apps/backend-mock/utils/jwt-utils.ts(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/backend-mock/utils/jwt-utils.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: post-update (ubuntu-latest)
- GitHub Check: post-update (windows-latest)
🔇 Additional comments (1)
apps/backend-mock/api/table/list.ts (1)
2-2: Imports standardized — LGTMConsistent use of h3's eventHandler/getQuery and centralized response utilities. Matches project conventions.
Also applies to: 4-8
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
apps/backend-mock/api/table/list.ts (1)
54-66: Normalize sortOrder and derive isDesc to avoid string[] and case issues.You already normalized
sortByand validated the key—good. Do the same forsortOrderand compute anisDescflag once to keep the comparator simple and correct even ifsortOrdercomes in asstring[]or with mixed case.Apply this diff within this block:
// 规范化 query 入参，兼容 string[] const sortKeyRaw = Array.isArray(sortBy) ? sortBy[0] : sortBy; + const sortOrderRaw = Array.isArray(sortOrder) ? sortOrder[0] : sortOrder; + const isDesc = + typeof sortOrderRaw === 'string' && + sortOrderRaw.trim().toLowerCase() === 'desc'; // 检查 sortBy 是否是 listData 元素的合法属性键 if ( typeof sortKeyRaw === 'string' && listData[0] && Object.prototype.hasOwnProperty.call(listData[0], sortKeyRaw) ) { // 定义数组元素的类型 type ItemType = (typeof listData)[0]; const sortKey = sortKeyRaw as keyof ItemType; // 将 sortBy 断言为合法键
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/backend-mock/api/table/list.ts(2 hunks)apps/backend-mock/utils/jwt-utils.ts(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/backend-mock/utils/jwt-utils.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: post-update (windows-latest)
- GitHub Check: post-update (ubuntu-latest)
🔇 Additional comments (2)
apps/backend-mock/api/table/list.ts (2)
2-2: LGTM: Consistent use of h3’s eventHandler/getQuery.Importing and using
eventHandlerandgetQueryfromh3is correct and aligns with the broader PR pattern.
4-8: LGTM: Response helpers are correctly imported and used.
sleep,unAuthorizedResponse, andusePageResponseSuccessare all used below; no dead imports and consistent response handling.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/backend-mock/api/table/list.ts (1)
54-66: Normalize and sanitize sortBy/sortOrder; make sortOrder case-insensitive.Currently, 'Desc' or 'DESC' won't be recognized. Also trimming sortBy reduces subtle bugs from whitespace.
Apply this diff within this block:
// 规范化 query 入参，兼容 string[] const sortKeyRaw = Array.isArray(sortBy) ? sortBy[0] : sortBy; const sortOrderRaw = Array.isArray(sortOrder) ? sortOrder[0] : sortOrder; + // 进一步规范化：去除空白并支持不区分大小写的 sortOrder + const sortKeyStr = typeof sortKeyRaw === 'string' ? sortKeyRaw.trim() : undefined; + const sortOrderNorm = + typeof sortOrderRaw === 'string' ? sortOrderRaw.trim().toLowerCase() : undefined; // 检查 sortBy 是否是 listData 元素的合法属性键 - if ( - typeof sortKeyRaw === 'string' && - listData[0] && - Object.prototype.hasOwnProperty.call(listData[0], sortKeyRaw) - ) { + if ( + typeof sortKeyStr === 'string' && + listData[0] && + Object.prototype.hasOwnProperty.call(listData[0], sortKeyStr) + ) { // 定义数组元素的类型 type ItemType = (typeof listData)[0]; - const sortKey = sortKeyRaw as keyof ItemType; // 将 sortBy 断言为合法键 - const isDesc = sortOrderRaw === 'desc'; + const sortKey = sortKeyStr as keyof ItemType; // 将 sortBy 断言为合法键 + const isDesc = sortOrderNorm === 'desc';
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/backend-mock/api/table/list.ts(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: post-update (windows-latest)
🔇 Additional comments (4)
apps/backend-mock/api/table/list.ts (4)
2-2: Good switch to explicit h3 APIs (eventHandler/getQuery).This aligns with the PR-wide pattern and improves clarity and typings for handlers.
4-8: Consistent use of response helpers and utilities.Importing sleep, unAuthorizedResponse, and usePageResponseSuccess standardizes responses across endpoints.
67-98: Robust, unified comparator; descending now works.Handles numbers, dates, booleans, and numeric-like strings; returns -result for desc. This addresses earlier pitfalls around type casting and broken descending order.
52-52: No structuredClone fallback needed
The root package.json specifies"engines": { "node": ">=20.10.0" }, and Node 20+ ships nativestructuredClone. All existing uses in apps/backend-mock will run without error under this constraint.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/backend-mock/api/table/list.ts (1)
88-93: Consider simplifying boolean comparison logic.The boolean comparison can be simplified while maintaining the same logic.
- } else if (typeof aValue === 'boolean' && typeof bValue === 'boolean') { - if (aValue === bValue) { - result = 0; - } else { - result = aValue ? 1 : -1; - } + } else if (typeof aValue === 'boolean' && typeof bValue === 'boolean') { + result = aValue === bValue ? 0 : (aValue ? 1 : -1);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/backend-mock/api/table/list.ts(2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
apps/backend-mock/api/table/list.ts (1)
apps/backend-mock/utils/response.ts (1)
usePageResponseSuccess(14-33)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: post-update (ubuntu-latest)
- GitHub Check: post-update (windows-latest)
🔇 Additional comments (7)
apps/backend-mock/api/table/list.ts (7)
2-2: LGTM: Proper TypeScript imports added.The explicit imports for
eventHandlerandgetQueryfrom 'h3' resolve TypeScript compilation errors.
4-8: LGTM: Import consolidation and additions.The imports are properly organized with
sleepadded to fix type errors while maintaining clean structure.
43-43: LGTM: Proper eventHandler wrapper implementation.The
eventHandlerwrapper correctly addresses TypeScript type safety requirements for the event parameter.
52-62: LGTM: Robust parameter normalization with proper bounds.The normalization logic correctly handles the
string | string[] | undefinedtypes fromgetQuery, with appropriate defaults and bounds checking (page ≥ 1, pageSize between 1-100).
65-77: LGTM: Improved query parameter handling with type safety.The normalization of sorting parameters and the type-safe property validation using
Object.prototype.hasOwnProperty.callproperly addresses the previous type casting concerns.
78-109: LGTM: Comprehensive type-aware sorting implementation.The unified comparator successfully addresses the previous issues:
- Handles multiple data types (numbers, dates, booleans, strings)
- Implements proper descending sort via
isDescflag- Uses numeric-aware string comparison with
localeCompare- Maintains type safety with
as unknowncastingThis implementation is much more robust than the previous version.
112-116: LGTM: Proper response formatting with normalized parameters.The response correctly uses the normalized and stringified page parameters, ensuring type compatibility with the
usePageResponseSuccesshelper.
修复 app/backend-mock 模块中的所有类型报错
Summary by CodeRabbit
Bug Fixes
Chores
Refactor
Known Issues