Skip to content

Turbopack: split basic side effects optimization test #82464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2025
Merged

Turbopack: split basic side effects optimization test #82464

merged 1 commit into from
Aug 8, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Aug 8, 2025 •
edited by padmaia
Loading

What?

Split the existing big basic test case into smaller test cases to make it easier to figure out problems

Closes PACK-5200

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Aug 8, 2025
@sokra Graphite App
Copy link
Member Author

sokra commented Aug 8, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Aug 8, 2025
Merged
Merged
Merged
Draft
@sokra sokra marked this pull request as ready for review August 8, 2025 08:56
@sokra sokra requested a review from mischnic August 8, 2025 08:56
mischnic
mischnic approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@mischnic mischnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I was always annoyed by that as well

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 8, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #82464 will not alter performance

Comparing sokra/split-side-effects-tests (43f6298) with canary (5869543)

Summary

✅ 9 untouched benchmarks

@sokra Graphite App
Copy link
Member Author

sokra commented Aug 8, 2025 •
edited
Loading

Merge activity

  • Aug 8, 9:35 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 8, 9:38 AM UTC: Graphite rebased this pull request as part of a merge.
  • Aug 8, 9:56 AM UTC: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'thank you, next', 'PR Stats', 'test ppr dev (4/6) / build').
  • Aug 8, 11:17 AM UTC: @sokra merged this pull request with Graphite.

@sokra sokra changed the base branch from sokra/reexport-only-by-default to graphite-base/82464 August 8, 2025 09:35
@sokra sokra changed the base branch from graphite-base/82464 to canary August 8, 2025 09:35
@austinderek austinderek mentioned this pull request Aug 8, 2025
Closed
@sokra sokra force-pushed the sokra/split-side-effects-tests branch from 1a2089f to 43f6298 Compare August 8, 2025 09:37
@ijjk
Copy link
Member

ijjk commented Aug 8, 2025 •
edited
Loading

Tests Passed

@sokra sokra merged commit 7f1ad3a into canary Aug 8, 2025
292 of 296 checks passed
@sokra sokra deleted the sokra/split-side-effects-tests branch August 8, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischnic mischnic mischnic approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokra @ijjk @mischnic